Page MenuHomePhabricator

Wall of code in <gallery> tag
Closed, DeclinedPublic

Description

See line 15 of this diff, where a lot of code starting with data:image/jpeg;base64,/... was added.
I inquired about this briefly in the IRC channel and Krenair provided the following evaluation:

16:16 <•Krenair> yeah so the gallery which has the filenames works, the gallery which tries to directly embed the image does not
16:17 <Elitre> so all that data:image/jpeg;base64,/etc etc mess, how did it end up there?
16:18 <•Krenair> I wonder if that's what happens in some browsers when the user tries to drag an image in directly
16:19 <•Krenair> ultimately the contents of that gallery tag is directly user-controlled
16:19 <•Krenair> so I think valid answers may include 'the user typed it in' or 'the user pasted it in'

Event Timeline

Elitre created this task.Jun 18 2015, 4:49 AM
Elitre raised the priority of this task from to Needs Triage.
Elitre updated the task description. (Show Details)
Elitre added a project: VisualEditor.
Elitre added a subscriber: Elitre.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2015, 4:49 AM

(A tracking task for galleries is T93407.)

Esanders closed this task as Declined.Jun 18 2015, 5:38 PM
Esanders claimed this task.
Esanders added a subscriber: Esanders.

Looks like the user dropped an image directly, a gallery would never generate this in normal usage.

Jdforrester-WMF moved this task from Blocked to To Triage on the VisualEditor board.