Page MenuHomePhabricator

Nearby pulls in `nav` styling
Closed, DuplicatePublic

Description

Not a problem now but might hit us later on.
When you visit Special: Nearby in Vector http://localhost:8888/w/index.php/Special:Nearby?useskin=vector
This pulls in some very generic but visible rules around styling a nav element that shouldn't be pulled in demonstrated by running this code:

$( '<nav>' ).prependTo( 'body' )

There are undoubtably some skins using a nav tag.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterDon't pull in initialisation code.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2015, 2:49 PM
Jdlrobson moved this task from Backlog to Bugs on the MobileFrontend board.Jul 20 2015, 5:16 PM

Change 229449 had a related patch set uploaded (by Jdlrobson):
WIP: Don't pull in initialisation code.

https://gerrit.wikimedia.org/r/229449

Jdlrobson set Security to None.

This has been dragging for some time now so I want to make sure this patch gets some attention so have pulled it into sprint (low priority compared to everything else).

https://gerrit.wikimedia.org/r/#/c/235776/
https://gerrit.wikimedia.org/r/#/c/229449/

Change 229449 merged by jenkins-bot:
Don't pull in initialisation code.

https://gerrit.wikimedia.org/r/229449