Nearby pulls in `nav` styling
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jun 26 2015, 2:49 PM

Description

Not a problem now but might hit us later on.
When you visit Special: Nearby in Vector http://localhost:8888/w/index.php/Special:Nearby?useskin=vector
This pulls in some very generic but visible rules around styling a nav element that shouldn't be pulled in demonstrated by running this code:

$( '<nav>' ).prependTo( 'body' )

There are undoubtably some skins using a nav tag.

Details

	Subject	Repo	Branch	Lines +/-
	Don't pull in initialisation code.	mediawiki/extensions/MobileFrontend	master	+437 -264

Customize query in gerrit

Related Objects

Mentioned In: rEMFR541b3eec976f: Don't pull in initialisation code.
rMEXT944895510bf4: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
T101795: Do not pull initialisation scripts along with JavaScript modules

Event Timeline

Jdlrobson created this task.Jun 26 2015, 2:49 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: MobileFrontend, Web-Team-Backlog.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2015, 2:49 PM

phuedx moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 26 2015, 4:34 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 20 2015, 5:16 PM

Jdlrobson mentioned this in T101795: Do not pull initialisation scripts along with JavaScript modules.Aug 12 2015, 5:25 PM

Jdlrobson closed this task as a duplicate of T101795: Do not pull initialisation scripts along with JavaScript modules.

Change 229449 had a related patch set uploaded (by Jdlrobson):
WIP: Don't pull in initialisation code.

https://gerrit.wikimedia.org/r/229449

gerritbot added a project: Patch-For-Review.Aug 12 2015, 6:11 PM

This has been dragging for some time now so I want to make sure this patch gets some attention so have pulled it into sprint (low priority compared to everything else).

https://gerrit.wikimedia.org/r/#/c/235776/
https://gerrit.wikimedia.org/r/#/c/229449/

Jdlrobson removed a project: Reading-Web-Sprint-55-π.Sep 4 2015, 12:15 AM

Change 229449 merged by jenkins-bot:
Don't pull in initialisation code.

https://gerrit.wikimedia.org/r/229449

• Konfused-Kitten mentioned this in rMEXT944895510bf4: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 14 2015, 12:24 AM

• bmansurov mentioned this in rEMFR541b3eec976f: Don't pull in initialisation code..Sep 14 2015, 12:24 AM