In Microsoft Edge (20.10158.0.0), opening MediaViewer works as usual, but closing it via ✖ or esc key only removes image and interface, not the black background. See screenshot (Phabricator's drop-to-upload doesn't work either).
Description
Details
Related Objects
- Mentioned In
- rEMMV849a6d9f16d2: Revert no-longer-needed fix for MS Edge browser
rMEXT0ad2c94da535: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer…
rMEXT9e4f15b92dfd: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer…
rEMMVe77df576152c: Workaround apparent bug in Edge's history.pushState - Mentioned Here
- T104531: Microsoft Edge user agent is not recognized
Event Timeline
I get a JS error when I test it in Edge in the current Windows 10 build:
Unspecified error.
in this line:
this.browserHistory.pushState( null, title, hash );
in mmv.bootstrap.js
Happens on live Commons and on a MediaWiki-Vagrant install.
Change 222279 had a related patch set uploaded (by Brion VIBBER):
Workaround apparent bug in Edge's history.pushState
Change 222279 merged by jenkins-bot:
Workaround apparent bug in Edge's history.pushState
I'm double-checking with dstorey @ microsoft which bug report system I should consider canonical report path; in the meantime I've got a confirmation via tweet that they're taking a look at the bug. :) https://twitter.com/dstorey/status/616699038042198016
A fix for this issue has been accepted into MS Edge and should be included in the Windows 10 release. I’ve verified the fix works on an internal branch, but you probably want to make sure it lands in a public build to verify./close.
A fix for this issue is in MS Edge in the latest public build of Windows 10, build 10240. If you could verify the fix, that would be great.
Change 224969 had a related patch set uploaded (by Brion VIBBER):
Revert no-longer-needed fix for MS Edge browser
@Dstoreymsft fix confirmed in Windows 10 build 10240 -- thanks!
Revert of the workaround is in changeset 224969 above, should go through in a few days once merged and gone through the usual release vetting.