Page MenuHomePhabricator

Update Popups gadget on Wikitech
Closed, ResolvedPublic

Description

MediaWiki:Gadget-popups.js on Wikitech needs updating after the recent API continuation format change. I've prepared an updated version in P870, so if someone with permission could copy it over to the gadget for me I'd be very grateful.

Normally I'd make this request on-wiki, but I couldn't find a page for that kind of thing at Wikitech, so Phabricator it is.

Event Timeline

MrStradivarius raised the priority of this task from to Low.
MrStradivarius updated the task description. (Show Details)
MrStradivarius subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MrStradivarius renamed this task from Update Popups gadget in Wikitech to Update Popups gadget on Wikitech.Jul 3 2015, 3:28 AM
MrStradivarius removed a project: Cloud-Services.
MrStradivarius set Security to None.

Wouldn't it make more sense to load it from elsewhere?

Per https://www.mediawiki.org/wiki/MediaWiki:Gadget-popups.js

// [[File:Wikipedia_Gadget-popups.js]] Pop-ups imported from enWP
mw.loader.load( '//en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-popups.js&action=raw&ctype=text/javascript&smaxage=21600&maxage=86400' );

I'm not sure we want to start loading random enwiki admin-controlled scripts on wikitech, @Reedy :)

Checking the Wikitech version against the enwiki version, I see that there are already quite a few differences in the code. It might be better to update it from enwiki rather than using the Paste that I made. I don't mind either way, but loading it with Reedy's code seems the easiest solution.

If you're worried about the security of gadgets on Wikitech, the best move might be to disable Popups completely, or at least give it a code audit. It does suspicious things with eval, it has its own unique templating system, and both those things add up to me not really trusting it. There may be security bugs in there already, wherever you load it from. In the long run it probably needs to be rewritten based on the Hovercards code, and made into an extension. At the moment it is pretty much abandonware.

And I made an edit for the eval thing. (on enwiki too)
Also, @MrStradivarius, you might find P878 helpful