edit (pencil) icons for sections misplaced in stable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Jul 8 2015, 3:54 AM

Description

I'm seeing this problem commonly on stable:

That's on the Carnism article. The edit icon is pushed down and overlaps the border for the header even though it appears there is plenty of room for it on the line with the header.

Details

	Subject	Repo	Branch	Lines +/-
	Correctly place the edit (pencil) icons for sections	mediawiki/extensions/MobileFrontend	master	+25 -11

Customize query in gerrit

Related Objects

Mentioned In: rMEXTb654d5bbdcc6: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR74a9ecd68af0: Correctly place the edit (pencil) icons for sections

Event Timeline

kaldari created this task.Jul 8 2015, 3:54 AM

kaldari raised the priority of this task from to Needs Triage.

kaldari updated the task description. (Show Details)

kaldari added a project: Web-Team-Backlog.

kaldari subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2015, 3:54 AM

It looks like there are 2 issues. First the icon anchor should probably come before the mw-headline span in the DOM (so that it doesn't get pushed down), and second, the span shouldn't have that huge right-padding on it. It seems weird that it's currently built the way it is. Did this change recently?

See carnism article https://en.m.wikipedia.org/wiki/Carnism?mobileaction=beta with a width of 350px for the viewport. Reproducible everywhere.

• Jhernandez edited projects, added Reading-Web-Sprint-51-YOLO, MobileFrontend; removed Web-Team-Backlog.Jul 8 2015, 10:02 AM

• Jhernandez set Security to None.

Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptJul 8 2015, 10:02 AM

• Jhernandez removed a project: Web-Team-Backlog.Jul 8 2015, 10:02 AM

• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-51-YOLO board.Jul 8 2015, 5:16 PM

kaldari claimed this task.Jul 8 2015, 5:17 PM

kaldari moved this task from To Do to Doing on the Reading-Web-Sprint-51-YOLO board.

Having trouble getting my new dev environment working, so I'd better let someone else take this for now...

kaldari removed kaldari as the assignee of this task.Jul 9 2015, 4:58 AM

kaldari moved this task from Doing to To Do on the Reading-Web-Sprint-51-YOLO board.

• bmansurov claimed this task.Jul 9 2015, 10:02 AM

• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-51-YOLO board.

Change 223769 had a related patch set uploaded (by Bmansurov):
Correctly place the edit (pencil) icons for sections

https://gerrit.wikimedia.org/r/223769

gerritbot added a project: Patch-For-Review.Jul 9 2015, 12:25 PM

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-51-YOLO board.Jul 9 2015, 12:25 PM

@kaldari to answer your question, yes that code changed recently. I added some explanation in the commit message.

kaldari closed this task as Resolved.Jul 10 2015, 4:26 AM

Change 223769 merged by jenkins-bot:
Correctly place the edit (pencil) icons for sections

https://gerrit.wikimedia.org/r/223769

• bmansurov mentioned this in rEMFR74a9ecd68af0: Correctly place the edit (pencil) icons for sections.Jul 10 2015, 4:26 AM

Diffusion mentioned this in rMEXTb654d5bbdcc6: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 10 2015, 4:26 AM

kaldari moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-51-YOLO board.Jul 10 2015, 4:30 AM

• Forrestbot added a project: WMF-deploy-2015-07-14_(1.26wmf14).Jul 10 2015, 5:00 AM

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-51-YOLO board.Jul 10 2015, 10:31 AM

edit (pencil) icons for sections misplaced in stableClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

edit (pencil) icons for sections misplaced in stable
Closed, ResolvedPublic
Actions