ipaddr 2.1.10 fails ip tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Jul 10 2015, 6:02 AM

Description

python package ipaddr 2.1.10 fails two of the IP tests

2 of 494 tests failed:
"02001:0000:1234:0000:0000:C1C0:ABCD:0876" match should be False - not OK
"2001:0000:1234:0000:00001:C1C0:ABCD:0876" match should be False - not OK

This is the ipaddr that is part of debian wheezy. Given it is in a stable, and has a low error rate, it could be considered acceptable.

However, 2.1.6-2.1.9 fail 17 additional tests

"02001:0000:1234:0000:0000:C1C0:ABCD:0876" match should be False - not OK
"2001:0000:1234:0000:00001:C1C0:ABCD:0876" match should be False - not OK
" 2001:0000:1234:0000:0000:C1C0:ABCD:0876" match should be False - not OK
"2001:0000:1234:0000:0000:C1C0:ABCD:0876 " match should be False - not OK
" 2001:0000:1234:0000:0000:C1C0:ABCD:0876 " match should be False - not OK
"2001:0000:1234: 0000:0000:C1C0:ABCD:0876" match should be False - not OK
"fe80:0000:0000:0000:0204:61ff:254.157.241.086" match should be False - not OK
"1:2:3::4:5:6:7:8:9" match should be False - not OK
"1111:2222:3333:4444:5555:6666:7777:8888::" match should be False - not OK
"::2222:3333:4444:5555:6666:7777:8888:9999" match should be False - not OK
"1111:2222:3333:4444:5555:6666:7777:8888:1.2.3.4" match should be False - not OK
"1111:2222:3333:4444:5555:6666:7777:1.2.3.4" match should be False - not OK
"1111:2222:3333:4444:5555:6666::1.2.3.4" match should be False - not OK
"::2222:3333:4444:5555:6666:7777:1.2.3.4" match should be False - not OK
"1111:2222:3333:4444:5555:1.2.3.4" match should be False - not OK
"1111:2222:3333:4444:1.2.3.4" match should be False - not OK
"1111:2222:3333:1.2.3.4" match should be False - not OK
"1111:2222:1.2.3.4" match should be False - not OK
"1111:1.2.3.4" match should be False - not OK

Unfortunately 2.1.5 is the debian squeeze version, and it is not easily installed via pip.

fwiw, ipaddr 1.x doesnt include an IPAddress function.

Details

	Subject	Repo	Branch	Lines +/-
	[deps] require ipaddress for Python 2	pywikibot/core	master	+82 -100
	Only allow ipaddr 2.1.10+	pywikibot/core	master	+37 -13

Customize query in gerrit

Related Objects

Mentioned In: rPWBCde3cdc3796e3: [deps] require ipaddress for Python 2
rPWBC15f5916cc223: Only allow ipaddr 2.1.10+
T103769: requests emits InsecurePlatformWarning
Mentioned Here: T76286: Use ipaddress module

Event Timeline

jayvdb created this task.Jul 10 2015, 6:02 AM

jayvdb claimed this task.

jayvdb raised the priority of this task from to Low.

jayvdb updated the task description. (Show Details)

jayvdb added a project: Pywikibot-tests.

jayvdb subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJul 10 2015, 6:02 AM

Change 224020 had a related patch set uploaded (by John Vandenberg):
Enable use-system-packages for Python 2.7

https://gerrit.wikimedia.org/r/224020

gerritbot added a project: Patch-For-Review.Jul 10 2015, 6:42 AM

As an aside, the ipaddr package was whitelisted for the purpose of running tests against a 'distro' environment: https://github.com/travis-ci/travis-ci/issues/3973

And 2.1.11 does not fail these two tests?

In T105443#1444494, @XZise wrote:

And 2.1.11 does not fail these two tests?

That is the version that our py2 builds are using now.
https://travis-ci.org/wikimedia/pywikibot-core/jobs/70310593#L247

Hmm. Redhat Enterprise Linux has ipaddr-2.1.9, which isnt available on pypi (any longer?) at https://pypi.python.org/simple/ipaddr/ , and the SRPM references http://ipaddr-py.googlecode.com/files/ as the download link, but that is a 404.

http://ftp.redhat.com/pub/redhat/linux/enterprise/6Server/en/os/SRPMS/python-ipaddr-2.1.9-3.el6.src.rpm

It should be similar to https://github.com/google/ipaddr-py/tree/master/tags/2.1.9 (eww , svn in git)

I'll test 2.1.9, to see if it may be supportable.

jayvdb mentioned this in T103769: requests emits InsecurePlatformWarning.Jul 11 2015, 10:57 AM

jayvdb updated the task description. (Show Details)Jul 11 2015, 11:23 AM

jayvdb set Security to None.

In T105443#1447249, @jayvdb wrote:

I'll test 2.1.9, to see if it may be supportable.

So RHEL's ipaddr 2.1.9 is as bad as debian squeeze's 2.1.5.

Are those errors worth considering acceptable?
IMO no; the regex is better.

tools.ip doesnt do version checking, so it will use any version of ipaddr that is installed.
Perhaps tools.ip needs to do version checking, so that it can fall back to using the regex instead of the module.

jayvdb updated the task description. (Show Details)Jul 25 2015, 2:28 AM

Change 224020 merged by jenkins-bot:
Only allow ipaddr 2.1.10

https://gerrit.wikimedia.org/r/224020

jayvdb mentioned this in rPWBC15f5916cc223: Only allow ipaddr 2.1.10+.Jul 27 2015, 9:24 PM

jayvdb closed this task as Resolved.Aug 24 2015, 11:03 PM

Change 566013 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [deps] require ipaddress for Python 2

https://gerrit.wikimedia.org/r/566013

Restricted Application added a project: Pywikibot. · View Herald TranscriptJan 20 2020, 12:25 PM

Change 566013 merged by jenkins-bot:
[pywikibot/core@master] [deps] require ipaddress for Python 2

https://gerrit.wikimedia.org/r/566013

Xqt mentioned this in rPWBCde3cdc3796e3: [deps] require ipaddress for Python 2.Feb 11 2020, 2:11 PM