Page MenuHomePhabricator

Find & Replace failure with respect to "After fixes" checked
Closed, ResolvedPublic

Description

In Find & Replace, normal settings, I have a minor rule for reducing space.

Find: \| {2,}([A-Za-z0-9\[])
Replace: | $1

It works under normal conditions, but if "After fixes" is checked, it doesn't.

At first I thought it had something to do with the bar (|), but upon discovering a similar problem with a similar rule, what's apparently happening is if "After fixes" is checked, but there are not any (checked) general or typo fixes, the rule doesn't run. But certainly it should run after those stages are complete, right? It seems to be working like "if no (checked) general or typo fixes, ignore this rule".

Event Timeline

Stevietheman raised the priority of this task from to Medium.
Stevietheman updated the task description. (Show Details)
Stevietheman added a project: AutoWikiBrowser.
Stevietheman renamed this task from Find & Replace failure with respect to detecting a bar (|) when "After fixes" checked to Find & Replace failure with respect to "After fixes" checked.Jul 22 2015, 7:39 PM
Stevietheman updated the task description. (Show Details)
Stevietheman set Security to None.

What's funny about this issue is that I've been noticing it for a long time, but it didn't dawn on me what aspect of AWB was the likely cause. I've been frustrated on many occasions by particular F&R changes not happening when I expected them to occur.

Rjwilmsi changed the task status from Open to Stalled.EditedJul 27 2015, 9:53 AM
Rjwilmsi subscribed.

@Stevietheman I can't replicate the issue. Please upload an AWB settings file which has the settings that replicate the problem, and advise an example article where you expect the F&R should be applied.

I noticed a similar problem. I ll try to duplicate it.

I'm sorry I haven't responded with further info. Instead of providing my entire settings, which is huge and distracting at this point, I will try to distill the issues in a simple settings file. Give me a few days.

I have simplified settings to a small file to demonstrate the issue.

I have two F&R's, one to replace "the" with "the " and another to replace "and" with "and ". The second one is marked 'Minor' and 'After fixes'. It doesn't seem to matter which order these entries appear in F&R.

If you run this as-is on the first article in the list, "and" doesn't get replaced even though there's no apparent reason it shouldn't be replaced.

Rjwilmsi claimed this task.

Thanks for the clear test case. Now I can replicate. rev 11379 fixes

Thank you. This fix right here will relieve my night terrors. :)

Yes. Usually we add there new features and not bugs of existing features.