Page MenuHomePhabricator
Create Task
Maniphest T106679

Crash: NullPointerException at ShareHandler.postShowShareToolTip(ShareHandler.java:255)
Closed, ResolvedPublic
Actions

Description

Stack trace:

java.lang.NullPointerException
at org.wikipedia.page.snippet.ShareHandler.postShowShareToolTip(ShareHandler.java:255)
at org.wikipedia.page.snippet.ShareHandler.showShareOnboarding(ShareHandler.java:246)
at org.wikipedia.page.snippet.ShareHandler.onTextSelected(ShareHandler.java:185)
at org.wikipedia.page.PageViewFragmentInternal.onActionModeShown(PageViewFragmentInternal.java:642)
at org.wikipedia.page.PageActivity.onSupportActionModeStarted(PageActivity.java:873)
at android.support.v7.app.AppCompatDelegateImplV7.b(AppCompatDelegateImplV7.java:680)
at android.support.v7.app.AppCompatDelegateImplV7.a(AppCompatDelegateImplV7.java:574)
at android.support.v7.app.AppCompatDelegateImplV14$AppCompatWindowCallbackV14.a(AppCompatDelegateImplV14.java:74)
at android.support.v7.app.AppCompatDelegateImplV14$AppCompatWindowCallbackV14.onWindowStartingActionMode(AppCompatDelegateImplV14.java:58)
at android.support.v7.internal.view.WindowCallbackWrapper.onWindowStartingActionMode(WindowCallbackWrapper.java:139)
at com.android.internal.policy.impl.PhoneWindow$DecorView.startActionMode(PhoneWindow.java:2647)
at com.android.internal.policy.impl.PhoneWindow$DecorView.startActionModeForChild(PhoneWindow.java:2628)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.ViewGroup.startActionModeForChild(ViewGroup.java:665)
at android.view.View.startActionMode(View.java:4537)
at android.webkit.WebViewClassic.updateSelectionInfo(WebViewClassic.java:14906)
at android.webkit.WebViewClassic.access$11300(WebViewClassic.java:275)
at android.webkit.WebViewClassic$PrivateHandler.handleMessage(WebViewClassic.java:13274)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:176)
at android.app.ActivityThread.main(ActivityThread.java:5317)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1102)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:869)
at dalvik.system.NativeStart.main(Native Method)

example ticket:
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8522824

Details

SubjectRepoBranchLines +/-
Fix possible crash involving the Share tooltip.apps/android/wikipediamaster+10 -9
Customize query in gerrit

Related Objects

Event Timeline

Dbrant created this task.Jul 23 2015, 12:50 PM
Dbrant raised the priority of this task from to High.
Dbrant updated the task description. (Show Details)
Dbrant added projects: Wikipedia-Android-App-Backlog, Mobile-App-Sprint-62-Android-Summer-Breeze.
Dbrant moved this task to Needs Triage on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2015, 12:50 PM
Dbrant moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Jul 23 2015, 12:50 PM
gerritbot subscribed.Jul 24 2015, 1:38 PM

Change 226714 had a related patch set uploaded (by Dbrant):
Fix possible crash involving the Share tooltip.

https://gerrit.wikimedia.org/r/226714

gerritbot added a project: Patch-For-Review.Jul 24 2015, 1:38 PM
Dbrant claimed this task.Jul 24 2015, 1:41 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-62-Android-Summer-Breeze board.
gerritbot added a comment.Jul 24 2015, 5:32 PM

Change 226714 merged by jenkins-bot:
Fix possible crash involving the Share tooltip.

https://gerrit.wikimedia.org/r/226714

Dbrant mentioned this in rAPAW7d1b6d6e4c42: Fix possible crash involving the Share tooltip..Jul 24 2015, 5:33 PM
Dbrant moved this task from Code Review to QA Signoff on the Mobile-App-Sprint-62-Android-Summer-Breeze board.Jul 24 2015, 5:34 PM
MBinder_WMF edited projects, added Mobile-App-Sprint-63-Android-Europium; removed Mobile-App-Sprint-62-Android-Summer-Breeze.Aug 3 2015, 6:40 PM
MBinder_WMF moved this task from To Do to QA Signoff on the Mobile-App-Sprint-63-Android-Europium board.
Etonkovidova subscribed.Aug 10 2015, 11:53 PM

Checked with 2.0.108-alpha-2015-08-07 on Nexus5(Android 5.1)

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-63-Android-Europium board.Aug 10 2015, 11:54 PM
Dbrant closed this task as Resolved.Aug 17 2015, 1:59 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-63-Android-Europium board.
Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL