Page MenuHomePhabricator

Test that/which self-hosted puppet masters resemble production
Closed, DeclinedPublic

Description

I had tested 67ecf83610337a4ee8eff75f0d26e69a0714dcf2. on toolsbeta-puppetmaster3, a self-hosted puppet master on a Precise instance. Unfortunately, @yuvipanda had to revert that in 9c040fb20303a9187f6b8de1a232edb4872778f4 because the production puppet master complained:

Error 400 on SERVER: validate_re(): 18 does not match "^[0-9]+$" at /etc/puppet/modules/cassandra/manifests/init.pp:236

So it needs to be tested/documented somewhere in https://wikitech.wikimedia.org/wiki/Puppet or https://wikitech.wikimedia.org/wiki/Puppet_coding what the differences between Labs and production puppet masters (Puppet version? Hiera? Ruby? Etc.) are.

Event Timeline

scfc raised the priority of this task from to Medium.
scfc updated the task description. (Show Details)
scfc added projects: acl*sre-team, Puppet.
scfc added subscribers: fgiunchedi, JanZerebecki, Krenair and 7 others.

(Though I did only test that change by default class parameters and not faking Hiera configuration, so that may be the culprit there … But as the production puppet masters are still black boxes from the outside, documenting the deployed versions can't hurt.)

scfc claimed this task.
  1. I retested the change with a fake Hiera configuration and it failed, so indeed my method for testing was faulty.
  2. On second thought, if the configuration of the production puppet masters was documented, it would likely not be updated :-). So, considering 1., rather than aiming at a moving target, I think it's more useful to look into this when the need arises.