Fix PageImagePersistenceHelper so it does not inappropriately set the namespace of all pages to null
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Deskana
	Aug 4 2015, 3:50 AM

Description

For the same reasons as in T96944, the PageImagePersistenceHelper should be fixed so that it does not inappropriately set the namespace of a page to null.

https://gerrit.wikimedia.org/r/#/c/207727/ provides a general idea how to do this. However, do not change the column indices like I did in that patch, as it causes issues like T107727.

Details

	Subject	Repo	Branch	Lines +/-
	Fix PageImagePersistenceHelper to set namespace as appropriate	apps/android/wikipedia	master	+11 -4
	Update SQL query generation to handle mainspace and other null params	apps/android/wikipedia	master	+122 -45

Customize query in gerrit

Related Objects

Mentioned In: T109376: Bug: Page image thumbnails in history, saved pages, etc. do not respect namespace
rAPAWa88975255d64: Update SQL query generation to handle mainspace and other null params
Mentioned Here: T96944: Fix HistoryEntryPersistenceHelper and SavedPagesPersistenceHelper so they do not inappropriately set the namespace of all pages to null
T107727: No "read more" suggestions shown on Main Page due to malformed search request.

Event Timeline

• Deskana created this task.Aug 4 2015, 3:50 AM

• Deskana raised the priority of this task from to Medium.

• Deskana updated the task description. (Show Details)

• Deskana added a project: Wikipedia-Android-App-Backlog.

• Deskana subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2015, 3:50 AM

• Deskana moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Aug 4 2015, 3:51 AM

Change 229319 had a related patch set uploaded (by Deskana):
Fix PageImagePersistenceHelper to set namespace as appropriate

https://gerrit.wikimedia.org/r/229319

gerritbot added a project: Patch-For-Review.Aug 5 2015, 4:29 AM

Change 231325 had a related patch set uploaded (by Mholloway):
Update SQL query generation to handle mainspace and other null params

https://gerrit.wikimedia.org/r/231325

Change 231325 merged by jenkins-bot:
Update SQL query generation to handle mainspace and other null params

https://gerrit.wikimedia.org/r/231325

• bearND mentioned this in rAPAWa88975255d64: Update SQL query generation to handle mainspace and other null params.Aug 14 2015, 9:25 PM

• Deskana mentioned this in T109376: Bug: Page image thumbnails in history, saved pages, etc. do not respect namespace.Aug 27 2015, 3:34 AM

Dbrant closed this task as Resolved.Sep 4 2015, 4:44 PM

Dbrant claimed this task.

Change 229319 abandoned by Deskana:
Fix PageImagePersistenceHelper to set namespace as appropriate

Reason:
This bug was fixed using another method, so this patch is no longer necessary.