| • Mholloway | |
| Aug 17 2015, 9:37 PM |
| F3364583: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3364605: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3364607: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3364588: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3364585: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3364611: pasted_file | |
| Feb 16 2016, 7:37 PM |
| F3140205: Screenshot_2015-12-23-13-55-07.png | |
| Dec 23 2015, 10:27 PM |
| F3140196: Screenshot_2015-12-23-13-52-27.png | |
| Dec 23 2015, 10:27 PM |
Steps to reproduce:
Probably related to, or a duplicate of, T107842: "Fix PageImagePersistenceHelper so it does not inappropriately set the namespace of all pages to null"
Re-checked with 2.1.136-alpha-2015-12-18.
View saved pages list, see no page image thumbnail.
There is a thumbnail for any page in Saved and Recent:
I can repro this but a fix is more complicated than I thought.
Example data used: "User:Braveheart" and "Braveheart". This is how the DB looks like:
The app currently does this query:
SELECT savedpages.namespace, savedpages.title, pageimages.imageName FROM savedpages LEFT OUTER JOIN pageimages ON (savedpages.site = pageimages.site AND savedpages.title = pageimages.title)
This is why we get the duplicate thumbnails.
One issue is that the title in the pageimages table includes the namespace prefix, see first screenshot.
Then I changed the app code to not add the prefix for pageimages entries.
I thought I could add the namespace columns to the join to make it work but this results in no thumbnails at all.
SELECT savedpages.namespace, savedpages.title, pageimages.imageName FROM savedpages LEFT OUTER JOIN pageimages ON (savedpages.site = pageimages.site AND savedpages.title = pageimages.title AND savedpages.namespace = pageimages.namespace)