Page MenuHomePhabricator
Create Task
Maniphest T108326

ProcessDialog fitLabel doesn't work for relative widths (e.g. full screen 100%)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Set your screen width to 270px
  2. Open the 'Search widget dialog' demo
  3. Observe it is trying to center the title, even though there is not enough room

Details

SubjectRepoBranchLines +/-
If ProcessDialog#fitLabel is called before dialog is open, deferoojs/uimaster+58 -17
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 7 2015, 2:38 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2015, 2:38 PM
gerritbot subscribed.Aug 7 2015, 2:39 PM

Change 230106 had a related patch set uploaded (by Esanders):
If ProcessDialog#fitLabel is called before dialog is open, defer

https://gerrit.wikimedia.org/r/230106

gerritbot added a project: Patch-For-Review.Aug 7 2015, 2:39 PM
Esanders added a comment.Aug 7 2015, 2:40 PM

Note the effect on mobile:

pasted_file (308×329 px, 21 KB)

Esanders added a project: VisualEditor-MediaWiki-Mobile.Aug 7 2015, 4:54 PM
Esanders set Security to None.
Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 7 2015, 4:54 PM
Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.Aug 7 2015, 6:03 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Aug 7 2015, 6:22 PM
gerritbot added a comment.Aug 7 2015, 7:55 PM

Change 230106 merged by jenkins-bot:
If ProcessDialog#fitLabel is called before dialog is open, defer

https://gerrit.wikimedia.org/r/230106

Esanders mentioned this in rGOJU336cf2d8241f: If ProcessDialog#fitLabel is called before dialog is open, defer.Aug 7 2015, 7:56 PM
Jdforrester-WMF closed this task as Resolved.Aug 7 2015, 7:56 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.3), WMF-deploy-2015-08-18_(1.26wmf19); removed OOjs-UI-next-release.Aug 12 2015, 11:50 PM
Jdforrester-WMF triaged this task as Medium priority.Aug 18 2015, 3:09 PM
Ryasmeen added a project: Verified-in-Phase0.Aug 19 2015, 11:04 PM
Ryasmeen added a project: Verified-in-Phase2.Aug 20 2015, 9:11 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Aug 26 2015, 1:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits