Page MenuHomePhabricator

Wrap Recent changes, Recent changes linked & Watchlist in <div class="mw-changeslist" />
Closed, ResolvedPublic

Description

Please wrap recent chages list in <div id="recentchanges">

<div id="recentchanges"> <!-- added -->
<h4>date</h4>
<div>
change<br />
change<br />
change<br />
</div>
<h4>date</h4>
<div>
change<br />
change<br />
change<br />
</div>
</div> <!-- added -->

Reason: easier CSS and DOM access to items, especially on projects with low
number of changes

setting of styles eg. for particular <a> elements has to be done really ugly way
now:
div.rcoptions + h4 + div a
div.rcoptions + h4 + div + h4 + div a
div.rcoptions + h4 + div + h4 + div + h4 + div a
etc. depending on how many days can appear on rc page

MediaWiki-Recent-changes div a
would be much easier.

Thanks


Version: 1.11.x
Severity: enhancement

Details

Reference
bz8844

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz8844.
Danny_B created this task.Feb 1 2007, 5:28 AM

robchur wrote:

*Just* for recent changes, or on all changes pages?

(In reply to comment #1)

*Just* for recent changes, or on all changes pages?

Very good idea - recent changes linked and watchlist would need it as well.

ayg wrote:

Probably it should be something like id="recentchanges-lists", id="recentchangeslinked-lists",
and so on, with class="changes-lists" or something. And maybe add a class="changes-list" to the
ul's while we're at it.

Note that it's already possible to do appropriate selection, though:

body.page-Special_Recentchanges ul.special a { ... }

(In reply to comment #3)

Probably it should be something like id="recentchanges-lists",

id="recentchangeslinked-lists",

and so on, with class="changes-lists" or something. And maybe add a

class="changes-list" to the

ul's while we're at it.

Note that it's already possible to do appropriate selection, though:

body.page-Special_Recentchanges ul.special a { ... }

I don't know if you plan to do these lists like <ul> (which would be great), but
they are not now, thus the example above does not work.

ayg wrote:

At enwiki's [[Special:Recentchanges]], I get:

<h4>1 February 2007</h4>
<ul class="special"><li>(<a href="/w/
index.php?title=Young_Buck&amp;curid=741134&amp;diff=104919445&amp;oldid=104869982" title="Young
Buck" tabindex="1">diff</a>) . . .

Are you using an old version?

brion added a comment.Feb 2 2007, 7:40 PM

Don't use an id, we can't guarantee it unique; there may be multiple lists shown
in a single document.

ayg wrote:

Oh, right, you can transclude RC.

(In reply to comment #5)

At enwiki's [[Special:Recentchanges]], I get:

<h4>1 February 2007</h4>
<ul class="special"><li>(<a href="/w/

index.php?title=Young_Buck&amp;curid=741134&amp;diff=104919445&amp;oldid=104869982"
title="Young

Buck" tabindex="1">diff</a>) . . .

Are you using an old version?

Enhanced recent changes are not rendered as <ul>, that's basically the deal ;-)

Changed component to "Watchlist"

Changed component back to "Page rendering" - this is not only watchlist issue as summary clearly says.

Given the solution mentioned in comment 3 I think this should be WONTFIXed.

(In reply to comment #3)

Note that it's already possible to do appropriate selection, though:

body.page-Special_Recentchanges ul.special a { ... }

WONTFIX per above.

REOPEN per comment #8

Change 97853 had a related patch set uploaded by Bartosz Dziewoński:
Wrap changes lists in <div class="mw-changeslist" />

https://gerrit.wikimedia.org/r/97853

Change 97853 merged by jenkins-bot:
Wrap changes lists in <div class="mw-changeslist" />

https://gerrit.wikimedia.org/r/97853