Apply tags to deletion
Closed, ResolvedPublic
Actions

Description

Could you add the possibility to apply tags through the API when deleting a page, like what has been done recently for regular edits ?

I'm using tags for identifying edits made by WPCleaner, and its main actions are page edit/creation through action=edit (which can be tagged), and page deletion through action=delete (which can't be tagged).
It currently looks strange in some cases: creation of a TODO subpage is tagged as WPCleaner, while its deletion when all actions are done has only a comment saying that it's done through WPCleaner.

Details

	Subject	Repo	Branch	Lines +/-
	Move tagging of API deletions to RC save	mediawiki/core	master	+22 -17
	Allow change tags to be added via API action=delete	mediawiki/core	master	+31 -27

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T97720 Add a tags parameter to API modules creating a logentry
		Resolved		Anomie	T108564 Apply tags to deletion

Event Timeline

NicoV created this task.Aug 10 2015, 7:43 AM

NicoV raised the priority of this task from to Needs Triage.

NicoV updated the task description. (Show Details)

NicoV added projects: MediaWiki-Change-tagging, MediaWiki-Action-API.

NicoV subscribed.

Restricted Application added subscribers: TTO, Aklapper. · View Herald TranscriptAug 10 2015, 7:43 AM

This interface should certainly be added. Until then, deletion log entries can be tagged post facto via a separate API request to action=tag.

Change 230526 had a related patch set uploaded (by TTO):
Allow change tags to be added via API action=delete

https://gerrit.wikimedia.org/r/230526

gerritbot added a project: Patch-For-Review.Aug 10 2015, 12:44 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Aug 10 2015, 2:36 PM

TTO moved this task from Backlog to Feature requests on the MediaWiki-Change-tagging board.Sep 9 2015, 1:20 PM

Change 230526 had a related patch set uploaded (by TTO):
Allow change tags to be added via API action=delete

https://gerrit.wikimedia.org/r/230526

Change 230526 merged by jenkins-bot:
Allow change tags to be added via API action=delete

https://gerrit.wikimedia.org/r/230526

This should be deployed to WMF wikis with 1.27.0-wmf.3, see https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap for the schedule.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MW-1.27-release-notes.Oct 8 2015, 3:00 PM

Anomie added a parent task: T97720: Add a tags parameter to API modules creating a logentry.Oct 14 2015, 6:40 PM

Ricordisamoa subscribed.Oct 14 2015, 8:49 PM

It works: https://test.wikipedia.org/w/index.php?title=Special%3ALog&type=&user=&page=Tto+page+506

Note that the deployment of 1.27.0-wmf.3 to non-test wikis has been delayed due to technical issues and personnel shortages, so this feature is not yet available on other sites.

Tagging deletions is only available from the API currently. I think Cenarium was asking for tagging via the UI in T88771; I'm not sure if it's a good idea though.

The summary of this task only mentions API. If Cenarium wants a web UI for it too, he's free to file a separate task for that.

I just noticed that APIDelete directly tags the deletion log (assuming the RC has been saved) instead of passing the tags for later tagging when the RC is saved like the others. Now that the RC save is deferred, it likely won't tag the RC any more. Same issue we had with editing when RC save got deferred. This will need fixing.

Change 312046 had a related patch set uploaded (by Cenarium):
Move tagging of API deletions to RC save

https://gerrit.wikimedia.org/r/312046

Change 312046 merged by jenkins-bot:
Move tagging of API deletions to RC save

https://gerrit.wikimedia.org/r/312046

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release-notes.Sep 23 2016, 8:00 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM