Page MenuHomePhabricator
Create Task
Maniphest T108773

[beta] TypeError: Cannot read property 'disable' of undefined TypeError: Cannot read property 'disable' of undefined
Closed, ResolvedPublic
Actions

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta
Click an image
Get a js error
Expected: no js error

Details

SubjectRepoBranchLines +/-
Check for instance before calling a methodmediawiki/extensions/MobileFrontendmaster+4 -1
Fix ImageOverlayBeta for thumb count < 2mediawiki/extensions/MobileFrontendmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 12 2015, 12:24 AM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2015, 12:24 AM
• Jhernandez triaged this task as Unbreak Now! priority.Aug 13 2015, 5:16 PM
• Jhernandez set Security to None.
• Jhernandez edited projects, added Reading-Web-Sprint-53-12-Monkeys; removed Web-Team-Backlog.
• Jhernandez moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-53-12-Monkeys board.
• bmansurov claimed this task.Aug 13 2015, 6:12 PM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.
gerritbot subscribed.Aug 13 2015, 6:41 PM

Change 231337 had a related patch set uploaded (by Bmansurov):
Check for instance before calling a method

https://gerrit.wikimedia.org/r/231337

gerritbot added a project: Patch-For-Review.Aug 13 2015, 6:41 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 6:42 PM
Jdlrobson added a comment.Aug 13 2015, 7:26 PM

Question on patchset.

gerritbot added a comment.Aug 13 2015, 7:41 PM

Change 231291 had a related patch set uploaded (by Florianschmidtwelzow):
Fix ImageOverlayBeta for thumb count < 2

https://gerrit.wikimedia.org/r/231291

Florian subscribed.Aug 13 2015, 7:41 PM
gerritbot added a comment.Aug 13 2015, 8:14 PM

Change 231291 merged by jenkins-bot:
Fix ImageOverlayBeta for thumb count < 2

https://gerrit.wikimedia.org/r/231291

Florian mentioned this in rEMFRd78dddec6e1a: Fix ImageOverlayBeta for thumb count < 2.Aug 13 2015, 8:14 PM
Diffusion mentioned this in rMEXTaa766f6facba: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 13 2015, 8:14 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 8:17 PM
gerritbot added a comment.Aug 13 2015, 8:26 PM

Change 231337 abandoned by Jdlrobson:
Check for instance before calling a method

Reason:
https://gerrit.wikimedia.org/r/231291

https://gerrit.wikimedia.org/r/231337

• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 13 2015, 9:00 PM
• Jhernandez closed this task as Resolved.Aug 14 2015, 10:29 AM
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.
• Jhernandez subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL