Page MenuHomePhabricator

URL schemes are case-insensitive
Closed, ResolvedPublic1 Story Points

Description

We have externalUrlProtocolsRegExp and unanchoredExternalUrlProtocolsRegExp -- but url protocols ("schemes", really) are case-insensitive. Need to audit to ensure our regexps are case-insensitive as well. (I'm pretty sure the autolink one in ve.ui.LinkAction is not, for instance.)

Details

Related Gerrit Patches:
VisualEditor/VisualEditor : masterMake URL schemes case-insensitive
mediawiki/extensions/VisualEditor : masterMake URL schemes case-insensitive

Event Timeline

cscott created this task.Aug 13 2015, 10:26 PM
cscott raised the priority of this task from to Medium.
cscott updated the task description. (Show Details)
cscott added a project: VisualEditor.
cscott added a subscriber: cscott.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 10:26 PM

Change 231485 had a related patch set uploaded (by Cscott):
Url schemes are case-insensitive

https://gerrit.wikimedia.org/r/231485

Change 231486 had a related patch set uploaded (by Cscott):
Url schemes are case-insensitive

https://gerrit.wikimedia.org/r/231486

Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 231486 merged by jenkins-bot:
Make URL schemes case-insensitive

https://gerrit.wikimedia.org/r/231486

Change 231485 merged by jenkins-bot:
Make URL schemes case-insensitive

https://gerrit.wikimedia.org/r/231485

Jdforrester-WMF closed this task as Resolved.Aug 18 2015, 3:09 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.