Maniphest T109013

URL schemes are case-insensitive
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We have externalUrlProtocolsRegExp and unanchoredExternalUrlProtocolsRegExp -- but url protocols ("schemes", really) are case-insensitive. Need to audit to ensure our regexps are case-insensitive as well. (I'm pretty sure the autolink one in ve.ui.LinkAction is not, for instance.)

Details

	Subject	Repo	Branch	Lines +/-
	Make URL schemes case-insensitive	VisualEditor/VisualEditor	master	+16 -3
	Make URL schemes case-insensitive	mediawiki/extensions/VisualEditor	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: rGVED28c686e9ef0d: Make URL schemes case-insensitive
rEVED3658b63cb58a: Make URL schemes case-insensitive

Event Timeline

cscott created this task.Aug 13 2015, 10:26 PM

cscott raised the priority of this task from to Medium.

cscott updated the task description. (Show Details)

cscott added a project: VisualEditor.

cscott subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 10:26 PM

Krenair subscribed.Aug 13 2015, 10:26 PM

Change 231485 had a related patch set uploaded (by Cscott):
Url schemes are case-insensitive

https://gerrit.wikimedia.org/r/231485

gerritbot added a project: Patch-For-Review.Aug 14 2015, 4:06 AM

Change 231486 had a related patch set uploaded (by Cscott):
Url schemes are case-insensitive

https://gerrit.wikimedia.org/r/231486

Jdforrester-WMF assigned this task to cscott.Aug 14 2015, 5:55 PM

Jdforrester-WMF added projects: VisualEditor-EditingTools, VisualEditor-CopyPaste.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Change 231486 merged by jenkins-bot:
Make URL schemes case-insensitive

https://gerrit.wikimedia.org/r/231486

Jdforrester-WMF mentioned this in rEVED3658b63cb58a: Make URL schemes case-insensitive.Aug 14 2015, 6:05 PM

Change 231485 merged by jenkins-bot:
Make URL schemes case-insensitive

https://gerrit.wikimedia.org/r/231485

cscott mentioned this in rGVED28c686e9ef0d: Make URL schemes case-insensitive.Aug 14 2015, 6:51 PM

• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 14 2015, 7:00 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Aug 15 2015, 9:19 PM

Jdforrester-WMF closed this task as Resolved.Aug 18 2015, 3:09 PM

Jdforrester-WMF subscribed.

Jdforrester-WMF removed a project: Patch-For-Review.Aug 18 2015, 7:00 PM

Ryasmeen added a project: Verified-in-Phase0.Aug 19 2015, 11:34 PM

Ryasmeen added a project: Verified-in-Phase2.Aug 20 2015, 9:14 PM