Maniphest T109664

Missing preventDefault on 'preview the result'
Closed, ResolvedPublic
Actions

Description

Clicking it adds # to the URL, jumps to the top, then jumps back (but not to the same place exactly).

Details

	Subject	Repo	Branch	Lines +/-
	WikitextEditorWidget: Prevent preview link from being followed	mediawiki/extensions/Flow	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rEFLWd017927801db: WikitextEditorWidget: Prevent preview link from being followed
rMEXT5fe6ee02219b: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Event Timeline

• Mattflaschen-WMF created this task.Aug 20 2015, 12:09 AM

• Mattflaschen-WMF raised the priority of this task from to Needs Triage.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.

• Mattflaschen-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 12:09 AM

Catrope claimed this task.Aug 20 2015, 12:18 AM

Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.

Change 232664 had a related patch set uploaded (by Catrope):
WikitextEditorWidget: Prevent preview link from being followed

https://gerrit.wikimedia.org/r/232664

gerritbot added a project: Patch-For-Review.Aug 20 2015, 12:20 AM

Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 20 2015, 12:21 AM

matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 20 2015, 12:03 PM

Change 232664 merged by jenkins-bot:
WikitextEditorWidget: Prevent preview link from being followed

https://gerrit.wikimedia.org/r/232664

Catrope mentioned this in rMEXT5fe6ee02219b: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 20 2015, 12:06 PM

Catrope mentioned this in rEFLWd017927801db: WikitextEditorWidget: Prevent preview link from being followed.

• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 20 2015, 1:00 PM

Checked in betalabs - flow-ui-wikitextEditorWidget-label-preview works smoothly.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 21 2015, 5:11 PM

• DannyH closed this task as Resolved.Aug 21 2015, 5:33 PM

• DannyH subscribed.

• DannyH added a project: OKR-Work.Aug 21 2015, 8:25 PM

• DannyH set Security to None.