Page MenuHomePhabricator

Without space after links, typing more text corrupts link
Closed, ResolvedPublic1 Estimated Story Points

Description

After I54d47e4e6146d58746fc4be1964f2593032ba22b was merged, there is no space after an inserted link. This makes the "annotation inheritance" behavior very odd!

Try this:

  1. put "http://example.com" on your clipboard
  2. paste in ve
  3. type "hello/there " after the paste. (no space at start, space after)
  4. the link text grows to include "hello", but the link url does not

I don't understand why (4) occurs, but it is definitely unexpected.

Also, the "trailing space" paste was intended to allow paste of url lists which contain multiple urls, as would occur when multiple links are dragged into VE (for example). Even if you don't want trailing spaces, there should definitely be some sort of whitespace between links in that case.

Event Timeline

cscott raised the priority of this task from to Needs Triage.
cscott updated the task description. (Show Details)
cscott added a project: VisualEditor.
cscott added subscribers: cscott, Esanders, Jdforrester-WMF.

I don't think the link continuation problem is specific to auto-linking. We are working link continuation at the moment. We should probably put spaces between multiple links though.

Change 233390 had a related patch set uploaded (by Esanders):
Put spaces between multiple links when pasting

https://gerrit.wikimedia.org/r/233390

Change 233390 merged by jenkins-bot:
Put spaces between multiple links when pasting

https://gerrit.wikimedia.org/r/233390

Jdforrester-WMF claimed this task.

As Ed says, the link continuation problem is broader.

Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.