Page MenuHomePhabricator
Create Task
Maniphest T110021

[Bug] aliases in entity selectors are too prominent
Closed, ResolvedPublic
Actions

Description

Aliases have been prominently added to the entity suggester. They are too prominent now. We need to find a way to make them less in-your-face.

Event Timeline

Lydia_Pintscher created this task.Aug 24 2015, 10:35 AM
Lydia_Pintscher raised the priority of this task from to High.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Lydia_Pintscher moved this task to consider for next sprint on the Wikidata board.
Lydia_Pintscher subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2015, 10:35 AM
Nikki subscribed.Aug 24 2015, 10:38 AM
• Jonas renamed this task from [Story] make aliases in entity selectors less prominent to [Bug] aliases in entity selectors are too prominent.Aug 24 2015, 2:40 PM
• Jonas set Security to None.
thiemowmde added projects: Patch-For-Review, Wikidata-Sprint-2015-08-18.EditedAug 25 2015, 12:52 PM
thiemowmde subscribed.

This Phabricator ticket misses an actual description of the issue (screenshot, steps to reproduce, example URL). :-(

https://www.wikidata.org/w/api.php?format=jsonfm&action=wbsearchentities&search=Gender&type=property&language=de
lists 1 alias.

https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&search=gender&format=jsonfm&language=en&entity=Q20412906
lists 1 alias (?), even if the entity does have multiple aliases.

https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&search=coord&format=jsonfm&entity=Q937
lists multiple aliases (?).

https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&search=&format=jsonfm&language=en&entity=Q20412906
(note the missing search term, which is what happens initially) lists all matching aliases.

Patch: https://github.com/Wikidata-lib/PropertySuggester/pull/141

Lydia_Pintscher moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.Aug 26 2015, 9:00 AM
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Aug 26 2015, 10:49 AM
daniel subscribed.EditedAug 27 2015, 2:05 PM

The pull request is merged. Now what? Does PropertySuggester need a release? Can we test this somewhere?

• Jonas closed this task as Resolved.Aug 27 2015, 5:11 PM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.
Lydia_Pintscher reopened this task as Open.Aug 31 2015, 1:22 PM

Should still be released.

Lydia_Pintscher moved this task from Done to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 31 2015, 1:24 PM
thiemowmde added a comment.Sep 1 2015, 7:20 AM

https://github.com/Wikidata-lib/PropertySuggester/pull/143 is sitting there and waiting. Why nobody merge and release?

thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Sep 1 2015, 7:21 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-01.Sep 1 2015, 12:45 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-09-01 board.
Lydia_Pintscher assigned this task to thiemowmde.Sep 2 2015, 8:43 AM
daniel added a comment.Sep 2 2015, 10:26 AM

I merged the pull request and tagged 2.4.1 https://github.com/Wikidata-lib/PropertySuggester/releases/tag/2.4.1

Lydia_Pintscher closed this task as Resolved.Sep 2 2015, 10:40 AM
Lydia_Pintscher moved this task from Review to Done on the Wikidata-Sprint-2015-09-01 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL