Make it possible to load the CirrusSearch configuration of another wiki in production
Closed, ResolvedPublic
Actions

Description

The work done in core to move globals behind a config object is the first step in being able to access the configuration of another wiki. We need to take this to the next step and actually read in the cirrussearch configuration of another wiki.

Ideally this should work both in wmf prod and in mediawiki-vagrant. This is *NOT* currently supported and we will have to figure out how to make it work. Currently the result of running InitializeSettings.php is cached but these are just the $wmgCirrusSearch* variables and not the $wgCirrusSearch* variables that we want.

Details

	Subject	Repo	Branch	Lines +/-
	Convert Searcher to use config object	mediawiki/extensions/CirrusSearch	master	+297 -199

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Deskana	T104466 EPIC: Cut zero results rate for search in half.
Resolved	• Deskana	T104505 EPIC: Improve results when users enter searches in other languages
Open	None	T3837 Add the ability to simultaneously search all languages on the on-wiki search page
Resolved	TJones	T109731 Run tests to measure the expected zero results change of running zero result enwiki queries against other languages (ru, jp, etc?)
Resolved	Smalyshev	T110078 Query elasticsearch language detection plugin and then issue query to suggested language wiki(s)
Resolved	Smalyshev	T110075 Make it possible to load the CirrusSearch configuration of another wiki in production
Resolved	Smalyshev	T110074 Refactor CirrusSearch\Searcher to remove usage of global variables and instead use a Config object

Event Timeline

EBernhardson created this task.Aug 24 2015, 5:54 PM

EBernhardson raised the priority of this task from to Needs Triage.

EBernhardson updated the task description. (Show Details)

EBernhardson added projects: Discovery-ARCHIVED, CirrusSearch.

EBernhardson added subscribers: EBernhardson, Aklapper, Legoktm.

Have you seen MW core's SiteConfiguration::getConfig function? It relies on the --wiki parameter to maintenance/getConfiguration.php, not sure if that will work in mediawiki-vagrant or not.

EBernhardson added a parent task: T110078: Query elasticsearch language detection plugin and then issue query to suggested language wiki(s).Aug 24 2015, 8:23 PM

I hadn't seen that SiteConfiguration implemented that, thanks @Krenair. I don't know if that is going to be a viable long term solution, but we can certainly use it for now in our initial testing and come back and do something nicer if it proves to be useful.

Change 233615 had a related patch set uploaded (by Smalyshev):
Convert Searcher to use config object

https://gerrit.wikimedia.org/r/233615

gerritbot added a project: Patch-For-Review.Aug 25 2015, 5:23 AM

Smalyshev subscribed.Aug 25 2015, 5:32 AM

EBernhardson assigned this task to Smalyshev.Aug 26 2015, 11:23 PM

EBernhardson added a project: Discovery-Search (Current work).

EBernhardson set Security to None.

EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.Aug 27 2015, 4:05 PM

There is a patch here, but it's a work in progress and is not ready to be merged. Keeping this in the "In progress" column for now.

• ksmith added a parent task: T109731: Run tests to measure the expected zero results change of running zero result enwiki queries against other languages (ru, jp, etc?).Aug 27 2015, 4:55 PM

• ksmith added a project: OKR-Work.Sep 1 2015, 6:05 PM

Smalyshev triaged this task as Medium priority.Sep 1 2015, 9:38 PM