i18n.messages_available and twget_keys does not work on Python 3 with empty i18n package
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Aug 25 2015, 9:58 AM

Description

Python 3 treats an empty i18n directory as an implicit namespace package (PEP 0420).

This causes i18n.messages_available to return True and twget to cause a AttributeError:

File "/home/ubuntu/pywikibot-core/tests/l10n_tests.py", line 67, in __new__
    keys = i18n.twget_keys(package)
  File "/home/ubuntu/pywikibot-core/pywikibot/i18n.py", line 619, in twget_keys
    pathname = os.path.join(os.path.dirname(mod.__file__), package)
AttributeError: 'module' object has no attribute '__file__'

Details

	Subject	Repo	Branch	Lines +/-
	Fix missing i18n git submodule on Python 3	pywikibot/core	master	+8 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T72936 Important tasks to be solved (tracking)
Resolved	Xqt	T60053 Pywikibot Python 3 compatibility (tracking)
Resolved	jayvdb	T110174 i18n.messages_available and twget_keys does not work on Python 3 with empty i18n package

Event Timeline

jayvdb created this task.Aug 25 2015, 9:58 AM

jayvdb raised the priority of this task from to Needs Triage.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot, Pywikibot-tests.

jayvdb subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptAug 25 2015, 9:58 AM

jayvdb added a parent task: T60053: Pywikibot Python 3 compatibility (tracking).Aug 25 2015, 10:01 AM

jayvdb renamed this task from i18n.messages_available does not work on Python 3 to i18n.messages_available and twget_keys does not work on Python 3 with empty i18n package.Aug 25 2015, 10:07 AM

jayvdb updated the task description. (Show Details)

jayvdb set Security to None.

Change 233688 had a related patch set uploaded (by John Vandenberg):
Fix missing i18n git submodule on Python 3

https://gerrit.wikimedia.org/r/233688

gerritbot added a project: Patch-For-Review.Aug 25 2015, 11:16 AM

Change 233688 merged by jenkins-bot:
Fix missing i18n git submodule on Python 3

https://gerrit.wikimedia.org/r/233688

jayvdb mentioned this in rPWBC6f22da1b4009: Fix missing i18n git submodule on Python 3.Aug 27 2015, 9:13 PM

jayvdb closed this task as Resolved.Aug 28 2015, 2:24 AM

jayvdb claimed this task.