Page MenuHomePhabricator
Create Task
Maniphest T110189

Running deleteEqualMessages.php causes "WikiPage::doDeleteArticleReal: Transaction already in progress"
Closed, ResolvedPublic
Actions

Description

channel: wfLogDBError
method: DatabaseBase::begin
message: WikiPage::doDeleteArticleReal: Transaction already in progress (from WikiPage::doDeleteArticleReal), performing implicit commit!

Whenever the deleteEqualMessages.script is run with --delete, this error appears hundreds of times in the Kibana "wfLogDBError" dashboard (depending on how many delete actions it performs, presumably once for each action?).

https://logstash.wikimedia.org/#dashboard/temp/AU9lieX9OkQDz4dSYD9b

Details

SubjectRepoBranchLines +/-
deleteEqualMessages.php: Avoid "Transaction already in progress" warningmediawiki/corewmf/1.26wmf20+6 -8
deleteEqualMessages.php: Avoid "Transaction already in progress" warningmediawiki/corewmf/1.26wmf19+6 -8
deleteEqualMessages.php: Avoid "Transaction already in progress" warningmediawiki/coremaster+6 -8
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Aug 25 2015, 3:42 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-Maintenance-system, MediaWiki-libs-Rdbms.
Krinkle added subscribers: Krinkle, aaron.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2015, 3:42 PM
jcrespo subscribed.Aug 25 2015, 3:44 PM
Krinkle updated the task description. (Show Details)Aug 25 2015, 3:44 PM
Krinkle set Security to None.
Krinkle removed a subscriber: jcrespo.
jcrespo added a project: Wikimedia-production-error.Aug 25 2015, 3:45 PM
jcrespo updated the task description. (Show Details)
jcrespo subscribed.
Krinkle added a comment.Aug 25 2015, 4:42 PM

It also causes a spike of these, coming from the same PHP process:

Memcached error for key "frwiki:messages:fr:lock" on server "127.0.0.1:11212": A TIMEOUT OCCURRED
Memcached error for key "frwiki:messages:fr:lock" on server "127.0.0.1:11212": A TIMEOUT OCCURRED
Memcached error for key "frwiki:messages:fr:lock" on server "127.0.0.1:11212": A TIMEOUT OCCURRED

And even a small number of these:

Memcached error for key "WANCache:v:frwiki:image_redirect:58cab542a1ccb6b693190ff1ac7bad0d" on server "127.0.0.1:11212": A TIMEOUT OCCURRED

No idea how this script is invoking image_redirect handling, but it does apparently, somehow.

Krinkle added a comment.Aug 25 2015, 4:52 PM

It seems the memcached issues are specific to running the script on tin (T103198). When running on terbium, those errors don't happen. However the original reported in this task still happens:

host: terbium
message: WikiPage::doDeleteArticleReal: Transaction already in progress (from WikiPage::doDeleteArticleReal), performing implicit commit!

Krenair subscribed.Aug 25 2015, 4:52 PM
aaron added a comment.Aug 25 2015, 9:11 PM

Is some extension triggering a page deletion inside a page deletion?

gerritbot subscribed.Aug 26 2015, 5:08 AM

Change 233909 had a related patch set uploaded (by PleaseStand):
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/233909

gerritbot added a project: Patch-For-Review.Aug 26 2015, 5:08 AM
gerritbot added a comment.Aug 26 2015, 5:59 AM

Change 233909 merged by jenkins-bot:
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/233909

PleaseStand mentioned this in rMW49107fcc291c: deleteEqualMessages.php: Avoid "Transaction already in progress" warning.Aug 26 2015, 5:59 AM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-09-01_(1.26wmf21).Aug 26 2015, 6:00 AM
gerritbot added a comment.Aug 26 2015, 5:16 PM

Change 234014 had a related patch set uploaded (by Krinkle):
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/234014

gerritbot added a comment.Aug 26 2015, 5:16 PM

Change 234015 had a related patch set uploaded (by Krinkle):
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/234015

gerritbot added a comment.Aug 26 2015, 5:27 PM

Change 234014 merged by jenkins-bot:
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/234014

Krinkle mentioned this in rMWb81e463e8695: deleteEqualMessages.php: Avoid "Transaction already in progress" warning.Aug 26 2015, 5:28 PM
gerritbot added a comment.Aug 26 2015, 5:28 PM

Change 234015 merged by jenkins-bot:
deleteEqualMessages.php: Avoid "Transaction already in progress" warning

https://gerrit.wikimedia.org/r/234015

Krinkle mentioned this in rMWa107f94aa3d1: deleteEqualMessages.php: Avoid "Transaction already in progress" warning.Aug 26 2015, 5:28 PM
• Forrestbot added projects: WMF-deploy-2015-08-18_(1.26wmf19), WMF-deploy-2015-08-25_(1.26wmf20).Aug 26 2015, 6:00 PM
• demon triaged this task as Medium priority.Sep 1 2015, 5:35 PM
• demon moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.
• demon subscribed.
Krinkle closed this task as Resolved.Oct 20 2015, 4:09 PM
Krinkle claimed this task.
• demon moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Oct 26 2015, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL