Page MenuHomePhabricator

Why does VisualEditor say that I can edit "Cite web", "Cite news", and "Cite journal" when it is only going to let me edit the pre-existing {{Cite book}}?
Closed, DeclinedPublic

Description

Current status:

  1. Open https://ca.wikipedia.org/wiki/Adam?veaction=edit
  2. Select the ref (middle of the first sentence). It's the local equivalent of {{cite book}}.
  3. Click the Cite menu. Everything is active. Choose something else (e.g., Cite web).
  4. Cite book opens anyway.

Desired outcome:

  1. Open https://ca.wikipedia.org/wiki/Adam?veaction=edit
  2. Select the ref (middle of the first sentence). It's the local equivalent of {{cite book}}.
  3. Click the Cite menu. Only Cite book, Basic, and Re-use would be active. Choose the option you want and can actually get.

Event Timeline

Jdforrester-WMF renamed this task from When a ref is selected, gray out the options in the Cite menu that aren't possible to Clicking "Cite X" when selecting an existing citation inserts a new one after it, rather than editing the existing one.Aug 26 2015, 8:26 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF subscribed.

This suffers from the same general conceptual belief as T110369: Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one – that clicking "insert X" when clicking on an X should edit it, not insert one. I'm not sure that's a good model (albeit one that some of the editor has used in the past and still does). We have edit buttons in the context to edit things…

Jdforrester-WMF claimed this task.

I prefer to retain our new direction of travel, wherein clicking 'edit' edits, and clicking on insertion tools insert.

Whatamidoing-WMF renamed this task from Clicking "Cite X" when selecting an existing citation inserts a new one after it, rather than editing the existing one to Why does VisualEditor say that I can edit "Cite web", "Cite news", and "Cite journal" when it is only going to let me edit the pre-existing {{Cite book}}?.Sep 8 2015, 6:42 PM

This reply seems to be about some completely different question.

Here is a different way to understand this request. When I have selected a "Cite book" footnote, then STOP showing this bad menu:

VisualEditor_references_more bad.png (597×416 px, 32 KB)

and START showing this good menu:

VisualEditor_references_more good.png (597×403 px, 29 KB)

No, it's actually saying that your expectation is wrong. Instead, we should stop clicking on anything in the toolbar from editing whatever you've selected, as opposed to only having done this for some things so far.

Clicking on the toolbar is currently the only method to change {{Cite book}} to Basic. Therefore, people will actually need to click on the toolbar to edit (not just "insert") citations.