Page MenuHomePhabricator
Create Task
Maniphest T110369

Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one
Closed, DeclinedPublic
Actions

Description

Steps to reproduce:

  1. Go to a citoid-enabled wiki and open a page containg a ref (e.g., ref "[1]")
  2. Select the ref, and click the "Cite" button in the toolbar.

Results:

A new "ref" appears. You now have "[1][2]" selected instead of just "[1]". The new [2] will disappear when you exit the dialog.

The cite dialog has also opened. It offers all the options, even ones that you can't have (see T110368). And it says "Add a citation" at the top, even though you can't add a new one here. You can only edit the one that you have selected.

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Aug 26 2015, 6:34 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added projects: VisualEditor-MediaWiki-References, VisualEditor, Citoid.
• Whatamidoing-WMF added subscribers: • Whatamidoing-WMF, Aklapper.
Mvolz added subscribers: Esanders, Krenair, Mvolz.Aug 26 2015, 7:18 PM

@Krenair @Esanders was this the result of moving the reference widget into citoid?

Jdforrester-WMF subscribed.Aug 26 2015, 7:28 PM
In T110369#1576614, @Mvolz wrote:

@Krenair @Esanders was this the result of moving the reference widget into citoid?

No, this was pre-existing before the code move.

Jdforrester-WMF renamed this task from The citoid-enabled Cite menu offers to "Add a citation" when you are "Editing" rather than "Adding" one to Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one.Aug 26 2015, 7:29 PM
Jdforrester-WMF set Security to None.

I've re-worded the title to be clear. I think this behaviour is better than the alternative. The staged selection feels a little off, but I'm not sure it's worth bothering too much about?

Jdforrester-WMF mentioned this in T110368: Why does VisualEditor say that I can edit "Cite web", "Cite news", and "Cite journal" when it is only going to let me edit the pre-existing {{Cite book}}?.Aug 26 2015, 8:27 PM
Mvolz moved this task from Backlog to Extension on the Citoid board.Aug 27 2015, 12:17 PM
• Whatamidoing-WMF added a comment.Aug 31 2015, 7:38 PM

The "alternative" that I want is:

  1. A new "ref" does not appear. You see just "[1]", for the footnote that you are actually editing.
  2. The cite dialog that opens shows impossible options as being grayed out.
  3. The cite dialog does not say "Add a citation" at the top; it says something like "Change this citation" instead.

I think this alternative is better than what we've got now.

Jdforrester-WMF closed this task as Declined.Sep 8 2015, 6:26 PM
Jdforrester-WMF claimed this task.

I prefer to retain our new direction of travel, wherein clicking 'edit' edits, and clicking on insertion tools insert.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits