Page MenuHomePhabricator
Create Task
Maniphest T111156

Some styles for MV are missing, link to description page invisible, button to open image in MV broken
Closed, ResolvedPublic
Actions

Description

On de.wikipedia and Commons some styles for MV seem to be missing, the button on file description pages looks like this:

(PNG-Grafik, 543 × 120 Pixel).png (120×543 px, 7 KB)

The button in MV to open the description page on Commons is invisible, as the blue background is missing, so the white icon and text can't be seen.

When im logged in on en.wikipedia the styles are present as expected, but logged out I can reproduce the same issues there, too.

(Always tested with File:Indochine_francaise_de.svg)

Details

SubjectRepoBranchLines +/-
Add missing dependency on 'mediawiki.ui.button'mediawiki/extensions/MultimediaViewerwmf/1.26wmf20+1 -0
Add missing dependency on 'mediawiki.ui.button'mediawiki/extensions/MultimediaViewerwmf/1.26wmf21+1 -0
Add missing dependency on 'mediawiki.ui.button'mediawiki/extensions/MultimediaViewermaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Sep 2 2015, 8:08 AM
Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added a project: MediaViewer.
Schnark subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 2 2015, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex claimed this task.Sep 2 2015, 9:00 AM
matmarex added subscribers: ori, matmarex.

Regression from de862298032c6567785842e031239424fadaf1ad. Patch coming; @ori, please deploy it when you're able.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 2 2015, 9:00 AM
gerritbot subscribed.Sep 2 2015, 9:01 AM

Change 235421 had a related patch set uploaded (by Bartosz Dziewoński):
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235421

gerritbot added a project: Patch-For-Review.Sep 2 2015, 9:01 AM
matmarex added a comment.Sep 2 2015, 9:02 AM

I didn't even realize that MMV uses MediaWiki UI buttons, I filed T111159 to replace them.

Thgoiter subscribed.EditedSep 2 2015, 9:03 AM

removed (didn't notice there were comments in the meantime)

matmarex triaged this task as High priority.Sep 2 2015, 9:04 AM
gerritbot added a comment.Sep 2 2015, 3:32 PM

Change 235421 merged by jenkins-bot:
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235421

matmarex mentioned this in rMEXT765b91a7eb5f: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Sep 2 2015, 3:32 PM
matmarex mentioned this in rEMMV34f7d9acb92c: Add missing dependency on 'mediawiki.ui.button'.
gerritbot added a comment.Sep 2 2015, 3:34 PM

Change 235483 had a related patch set uploaded (by Jforrester):
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235483

gerritbot added a comment.Sep 2 2015, 3:34 PM

Change 235484 had a related patch set uploaded (by Jforrester):
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235484

gerritbot added a comment.Sep 2 2015, 3:46 PM

Change 235484 merged by jenkins-bot:
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235484

gerritbot added a comment.Sep 2 2015, 3:46 PM

Change 235483 merged by jenkins-bot:
Add missing dependency on 'mediawiki.ui.button'

https://gerrit.wikimedia.org/r/235483

matmarex mentioned this in rMW7fca48573878: Updated mediawiki/core Project: mediawiki/extensions/MultimediaViewer….Sep 2 2015, 3:46 PM
matmarex mentioned this in rMW8f4f6df8ce0e: Updated mediawiki/core Project: mediawiki/extensions/MultimediaViewer….
Jdforrester-WMF mentioned this in rEMMVd59badb733d6: Add missing dependency on 'mediawiki.ui.button'.Sep 2 2015, 3:46 PM
Jdforrester-WMF mentioned this in rEMMV694292b4df7b: Add missing dependency on 'mediawiki.ui.button'.
• Forrestbot added projects: WMF-deploy-2015-09-01_(1.26wmf21), WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-08-25_(1.26wmf20).Sep 2 2015, 4:00 PM
Jdforrester-WMF closed this task as Resolved.Sep 2 2015, 4:12 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Untriaged to Done on the Multimedia board.Sep 11 2015, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL