Page MenuHomePhabricator
Create Task
Maniphest T111287

Remove mobile.experiments module from MobileFrontend
Closed, ResolvedPublic
Actions

Description

Now this is in core we should make exclusive use of this. @phuedx able to give a gut estimation of how trivial this is? Going to keep it in the background for this sprint in case we need more tasks.

Details

SubjectRepoBranchLines +/-
Remove mobile.experiments as mediawiki.experiments is in coremediawiki/extensions/MobileFrontendmaster+0 -238
Remove mobile.experiments in favor of mediawiki.experimentsmediawiki/extensions/Gathermaster+19 -8
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 3 2015, 12:02 AM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: MobileFrontend, Reading-Web-Sprint-55-π.
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson added subscribers: Jdlrobson, phuedx.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 12:02 AM
phuedx added a comment.Sep 3 2015, 10:24 AM

Half a story point at best. Gather is the only client of the original code so, as well as removing the mobile.experiments module and associated configuration variable, you'll have to tweak the Gather codebase too.

phuedx added a comment.Sep 3 2015, 10:24 AM

One story point at worst.

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-55-π board.Sep 3 2015, 10:15 PM
Jdlrobson triaged this task as Low priority.Sep 8 2015, 11:43 PM

Since it's tech debt I'm not going to assign points to it. It's a points penalty but given it's small I think someone should go ahead and do this if they have time.

phuedx added a comment.Sep 9 2015, 4:55 PM

Make sure that Gather isn't broken by the removal of the module.

• rmoen claimed this task.Sep 10 2015, 7:01 PM
• rmoen set Security to None.
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-55-π board.
• rmoen added a comment.EditedSep 10 2015, 8:51 PM

@Jdlrobson, @phuedx: Seems like an experiment hasn't been defined for Gather and it's initializing by default in beta. Should I simply remove the bucketing work and it can be reintroduced if such an experiment is defined?

gerritbot subscribed.Sep 10 2015, 9:09 PM

Change 237501 had a related patch set uploaded (by Robmoen):
Remove mobile.experiments as mediawiki.experiments is in core

https://gerrit.wikimedia.org/r/237501

gerritbot added a project: Patch-For-Review.Sep 10 2015, 9:09 PM

Change 237500 had a related patch set uploaded (by Robmoen):
Remove mobile.experiments dependency

https://gerrit.wikimedia.org/r/237500

• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-55-π board.Sep 10 2015, 9:11 PM
Krinkle subscribed.Sep 10 2015, 9:26 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 10 2015, 10:17 PM
• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 11 2015, 12:13 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 11 2015, 9:17 AM
• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 11 2015, 6:09 PM
gerritbot added a comment.Sep 11 2015, 7:55 PM

Change 237500 merged by jenkins-bot:
Remove mobile.experiments in favor of mediawiki.experiments

https://gerrit.wikimedia.org/r/237500

• rmoen mentioned this in rMEXT4a1ff3201e25: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 11 2015, 7:55 PM
• rmoen mentioned this in rEGAT0b1f45425a41: Remove mobile.experiments in favor of mediawiki.experiments.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 8:00 PM
gerritbot added a comment.Sep 11 2015, 10:00 PM

Change 237501 merged by jenkins-bot:
Remove mobile.experiments as mediawiki.experiments is in core

https://gerrit.wikimedia.org/r/237501

• rmoen mentioned this in rEMFRcac86755cbdc: Remove mobile.experiments as mediawiki.experiments is in core.Sep 11 2015, 10:00 PM
• rmoen mentioned this in rMEXT0df976b74f90: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 11 2015, 10:12 PM
Jdlrobson closed this task as Resolved.Sep 11 2015, 11:59 PM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.

Technical task

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits