Page MenuHomePhabricator
Create Task
Maniphest T111771

ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist.
Closed, ResolvedPublic
Actions

Description

A new test for missing image files referenced from CSS I'm adding in https://gerrit.wikimedia.org/r/#/c/235903/ exposed an issue:

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/30048/consoleFull:

00:50:20 3) ResourcesTest::testFileExistence with data set #1260 ('/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif', 'ext.flow.ui', '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif')
00:50:20 File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist.
00:50:20 Failed asserting that file "/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif" exists.
00:50:20 
00:50:20 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/structure/ResourcesTest.php:24
00:50:20 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131

You could probably be using jquery.spinner instead?

Details

SubjectRepoBranchLines +/-
Remove containing file as intended.mediawiki/extensions/Flowmaster+0 -0
Remove dead codemediawiki/extensions/Flowmaster+0 -9
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 8 2015, 10:34 AM
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added a project: StructuredDiscussions.
matmarex subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 8 2015, 10:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Mattflaschen-WMF subscribed.Sep 8 2015, 10:29 PM

Good catch, thanks.

• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 8 2015, 10:30 PM
• Mattflaschen-WMF set Security to None.
gerritbot subscribed.Sep 8 2015, 10:30 PM

Change 236978 had a related patch set uploaded (by Mattflaschen):
Remove dead code

https://gerrit.wikimedia.org/r/236978

gerritbot added a project: Patch-For-Review.Sep 8 2015, 10:30 PM
• Mattflaschen-WMF claimed this task.Sep 8 2015, 10:31 PM
• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
gerritbot added a comment.Sep 8 2015, 10:35 PM

Change 236978 merged by jenkins-bot:
Remove dead code

https://gerrit.wikimedia.org/r/236978

• Mattflaschen-WMF mentioned this in rEFLW6ac48db1c55d: Remove dead code.Sep 8 2015, 10:36 PM
Diffusion mentioned this in rMEXTb2346c0836d3: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Sep 8 2015, 10:36 PM
gerritbot added a comment.Sep 8 2015, 10:41 PM

Change 236981 had a related patch set uploaded (by Mattflaschen):
Remove containing file as intended.

https://gerrit.wikimedia.org/r/236981

gerritbot added a comment.Sep 8 2015, 10:44 PM

Change 236981 merged by jenkins-bot:
Remove containing file as intended.

https://gerrit.wikimedia.org/r/236981

Diffusion mentioned this in rMEXTb0ebcfb08ce1: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Sep 8 2015, 10:44 PM
• Mattflaschen-WMF mentioned this in rEFLWa8dfee422a56: Remove containing file as intended..Sep 8 2015, 10:45 PM
matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 9 2015, 9:20 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 9:12 PM
• DannyH added a project: OKR-Work.Sep 14 2015, 10:48 PM
matmarex mentioned this in rMW8f5cd11d82fa: ResourcesTest: Detect missing files in url(...) expressions.Sep 17 2015, 7:46 PM
Etonkovidova subscribed.Sep 17 2015, 11:13 PM

Starting with https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/30049/testReport/(root)/ResourcesTest__testFileExistence/testFileExistence_with_data_set__1260/
the test for

File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist.
Failed asserting that file "/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif" exists.

marked as Fixed, then Passed.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 17 2015, 11:13 PM
• DannyH closed this task as Resolved.Sep 18 2015, 5:34 PM
• DannyH subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL