Page MenuHomePhabricator

Ctrl+click (or middle click) should open notifications in a new window
Closed, ResolvedPublic

Description

It used to work, and now that we're using OO.ui.SelectWidget, the 'choose' feature can't differentiate between middle click or ctrl-click.

Whichever way we fix this in Echo, it should also probably go upstream to allow this behavior in SelectWidget.

Event Timeline

Mooeypoo created this task.Sep 9 2015, 8:33 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: Notifications.
Mooeypoo added a subscriber: Mooeypoo.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 9 2015, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 237280 had a related patch set uploaded (by Mooeypoo):
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237280

Mooeypoo claimed this task.Sep 9 2015, 10:23 PM
Ltrlg awarded a token.Sep 11 2015, 2:33 PM
Ltrlg added a subscriber: Ltrlg.

Change 237280 merged by jenkins-bot:
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237280

Change 237708 had a related patch set uploaded (by Legoktm):
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237708

Change 237708 merged by jenkins-bot:
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237708

Legoktm closed this task as Resolved.Sep 11 2015, 6:15 PM
Legoktm added a subscriber: Legoktm.