Page MenuHomePhabricator
Create Task
Maniphest T112004

Ctrl+click (or middle click) should open notifications in a new window
Closed, ResolvedPublic
Actions

Description

It used to work, and now that we're using OO.ui.SelectWidget, the 'choose' feature can't differentiate between middle click or ctrl-click.

Whichever way we fix this in Echo, it should also probably go upstream to allow this behavior in SelectWidget.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Wrap notifications with a link for native click behaviormediawiki/extensions/Echowmf/1.26wmf22+21 -33
Wrap notifications with a link for native click behaviormediawiki/extensions/Echomaster+21 -33
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Sep 9 2015, 8:33 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: Notifications (Echo).
Mooeypoo subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 9 2015, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 9 2015, 10:13 PM

Change 237280 had a related patch set uploaded (by Mooeypoo):
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237280

gerritbot added a project: Patch-For-Review.Sep 9 2015, 10:13 PM
Mooeypoo claimed this task.Sep 9 2015, 10:23 PM
Quiddity subscribed.Sep 10 2015, 10:11 PM

Also reported onwiki at https://www.mediawiki.org/wiki/Topic:Sooghkix1i8xa4f6

Legoktm merged a task: T112231: Command-clicking (Ctrl-clicking) on a link in notifications opens new tab and opens content in existing tab.Sep 11 2015, 4:10 AM
Legoktm added a subscriber: Jonesey95.
Ltrlg awarded a token.Sep 11 2015, 2:33 PM
Ltrlg subscribed.
gerritbot added a comment.Sep 11 2015, 5:07 PM

Change 237280 merged by jenkins-bot:
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237280

Diffusion mentioned this in rMEXTead247a88d37: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 11 2015, 5:08 PM
Legoktm mentioned this in rECHObfd27ae7126e: Wrap notifications with a link for native click behavior.Sep 11 2015, 5:08 PM
gerritbot added a comment.Sep 11 2015, 5:08 PM

Change 237708 had a related patch set uploaded (by Legoktm):
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237708

gerritbot added a comment.Sep 11 2015, 5:59 PM

Change 237708 merged by jenkins-bot:
Wrap notifications with a link for native click behavior

https://gerrit.wikimedia.org/r/237708

Legoktm mentioned this in rECHO90f41682fe62: Wrap notifications with a link for native click behavior.Sep 11 2015, 5:59 PM
Diffusion mentioned this in rMW88f87bfb9489: Updated mediawiki/core Project: mediawiki/extensions/Echo….Sep 11 2015, 5:59 PM
ReleaseTaggerBot added projects: WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 6:00 PM
Legoktm closed this task as Resolved.Sep 11 2015, 6:15 PM
Legoktm subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits