Page MenuHomePhabricator
Create Task
Maniphest T112099

Fix easy problems reported by RuboCop in Gather
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Metrics/LineLength RuboCop offensemediawiki/extensions/Gathermaster+15 -20
Fixed Style/AlignParameters RuboCop offensemediawiki/extensions/Gathermaster+2 -9
Fixed Style/HashSyntax RuboCop offensemediawiki/extensions/Gathermaster+2 -8
Fixed Style/IndentationWidth RuboCop offensemediawiki/extensions/Gathermaster+1 -8
Fixed Style/RegexpLiteral RuboCop offensemediawiki/extensions/Gathermaster+1 -8
Fixed Style/SpaceAfterColon RuboCop offensemediawiki/extensions/Gathermaster+1 -7
Fixed Style/SpaceAroundOperator RuboCop offensemediawiki/extensions/Gathermaster+2 -10
Fixed Style/SpaceInsideParens RuboCop offensemediawiki/extensions/Gathermaster+5 -12
Fixed Style/StringLiterals RuboCop offensemediawiki/extensions/Gathermaster+6 -13
Fixed Style/TrailingBlankLines RuboCop offensemediawiki/extensions/Gathermaster+0 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Sep 10 2015, 2:33 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added projects: Browser-Tests-Infrastructure, Gather.
zeljkofilipin added subscribers: zeljkofilipin, Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 2:33 PM
gerritbot subscribed.Sep 10 2015, 2:40 PM

Change 237387 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/237387

gerritbot added a project: Patch-For-Review.Sep 10 2015, 2:40 PM
gerritbot added a comment.Sep 10 2015, 11:49 PM

Change 237387 merged by jenkins-bot:
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/237387

Jdlrobson mentioned this in rEGATe784581509a6: Fixed Style/TrailingBlankLines RuboCop offense.Sep 10 2015, 11:49 PM
Diffusion mentioned this in rMEXTb3d852b7fff7: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 10 2015, 11:49 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 12:00 AM
gerritbot added a comment.Sep 11 2015, 7:47 AM

Change 237592 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/237592

gerritbot added a comment.Sep 11 2015, 7:48 AM

Change 237593 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideParens RuboCop offense

https://gerrit.wikimedia.org/r/237593

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237594 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAroundOperator RuboCop offense

https://gerrit.wikimedia.org/r/237594

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237595 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAfterColon RuboCop offense

https://gerrit.wikimedia.org/r/237595

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237596 had a related patch set uploaded (by Zfilipin):
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/237596

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237597 had a related patch set uploaded (by Zfilipin):
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/237597

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237598 had a related patch set uploaded (by Zfilipin):
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/237598

gerritbot added a comment.Sep 11 2015, 7:55 AM

Change 237599 had a related patch set uploaded (by Zfilipin):
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/237599

gerritbot added a comment.Sep 11 2015, 9:53 AM

Change 237611 had a related patch set uploaded (by Zfilipin):
Fixed Metrics/LineLength RuboCop offense

https://gerrit.wikimedia.org/r/237611

gerritbot added a comment.Sep 16 2015, 10:19 PM

Change 237592 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/237592

gerritbot added a comment.Sep 16 2015, 10:19 PM

Change 237593 merged by jenkins-bot:
Fixed Style/SpaceInsideParens RuboCop offense

https://gerrit.wikimedia.org/r/237593

gerritbot added a comment.Sep 16 2015, 10:19 PM

Change 237594 merged by jenkins-bot:
Fixed Style/SpaceAroundOperator RuboCop offense

https://gerrit.wikimedia.org/r/237594

zeljkofilipin mentioned this in rMEXTd698ca2980f5: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 16 2015, 10:20 PM
zeljkofilipin mentioned this in rMEXT7176e4f3505b: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….
zeljkofilipin mentioned this in rMEXT1901a68c8fee: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….
gerritbot added a comment.Sep 16 2015, 10:21 PM

Change 237595 merged by jenkins-bot:
Fixed Style/SpaceAfterColon RuboCop offense

https://gerrit.wikimedia.org/r/237595

zeljkofilipin mentioned this in rMEXTe3346546ba36: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 16 2015, 10:22 PM
zeljkofilipin mentioned this in rEGAT78c47e1270f0: Fixed Style/SpaceInsideParens RuboCop offense.
zeljkofilipin mentioned this in rEGATe4c5d63c3fc7: Fixed Style/StringLiterals RuboCop offense.
zeljkofilipin mentioned this in rEGATd7f5d823841e: Fixed Style/SpaceAroundOperator RuboCop offense.
zeljkofilipin mentioned this in rEGAT53b7d0ae2f8e: Fixed Style/SpaceAfterColon RuboCop offense.
gerritbot added a comment.Sep 16 2015, 10:23 PM

Change 237596 merged by jenkins-bot:
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/237596

zeljkofilipin mentioned this in rMEXTde4deba1967d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 16 2015, 10:23 PM
gerritbot added a comment.Sep 16 2015, 10:27 PM

Change 237597 merged by jenkins-bot:
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/237597

zeljkofilipin mentioned this in rEGATacd99b6508c7: Fixed Style/RegexpLiteral RuboCop offense.Sep 16 2015, 10:28 PM
zeljkofilipin mentioned this in rEGATc41d00cd54de: Fixed Style/IndentationWidth RuboCop offense.
zeljkofilipin mentioned this in rMEXTdfaf0ed8d35d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….
gerritbot added a comment.Sep 16 2015, 10:28 PM

Change 237598 merged by jenkins-bot:
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/237598

zeljkofilipin mentioned this in rMEXTe2aad78d63c4: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 16 2015, 10:31 PM
zeljkofilipin mentioned this in rEGATea330317c83e: Fixed Style/HashSyntax RuboCop offense.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 16 2015, 11:00 PM
gerritbot added a comment.Sep 17 2015, 8:02 AM

Change 237599 merged by Zfilipin:
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/237599

zeljkofilipin mentioned this in rMEXT8bb98df92b6d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 17 2015, 8:02 AM
zeljkofilipin mentioned this in rEGATb24a27892063: Fixed Style/AlignParameters RuboCop offense.
gerritbot added a comment.Sep 17 2015, 8:24 AM

Change 237611 merged by jenkins-bot:
Fixed Metrics/LineLength RuboCop offense

https://gerrit.wikimedia.org/r/237611

zeljkofilipin mentioned this in rMEXTa6833525d9fc: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 17 2015, 8:24 AM
zeljkofilipin mentioned this in rEGATc8520ef7153e: Fixed Metrics/LineLength RuboCop offense.
zeljkofilipin closed this task as Resolved.Sep 17 2015, 8:35 AM
greg added a project: Essential-Work.Sep 21 2015, 8:52 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 25 2015, 2:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits