This is a reminder to remove the subscriber to the history-link-loaded event in resources/mobile.head/init.js
The change https://gerrit.wikimedia.org/r/#/c/236191/ removes the execution of this event in the page HTML. However cached pages will still be firing, so the decision was made in the change to leave this line until sometime in the future.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • jhobs | T112315 Remove history-link-loaded event listener once cache expires | |||
| Resolved | • JKatzWMF | T115132 Spike: Assess impact of moving hamburger code to the bottom of the page |
Change 237705 had a related patch set uploaded (by Jdlrobson):
Last modified code no longer needs to be loaded in head
I think we can do this now provided we do so after tomorrows cut off. Merged Sep 11, 2015. Deployed 17th.
Y'all should probably C:-2 it so that eager reviewers (read: me) don't merge it too soon…
Change 237705 merged by jenkins-bot:
Last modified code no longer needs to be loaded in head
Seems we have mw.loader.using( 'mobile.head', function () {mw.mobileFrontend.emit( 'header-loaded' );} ); in the head. This seems to create an empty file but I think we should kill this as part of this bug too.
Change 244609 had a related patch set uploaded (by Jhobs):
Remove 'header-loaded' event
@bmansurov @phuedx please ensure there are +1s from both of you before merging. Let's make sure we all agree this is the right thing to do.