Maniphest T112361

Syntax error in IE 8 (jquery.i18n)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Sep 12 2015, 7:36 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

There is a report that ULS throws a syntax error in IE 8: https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#.22Benachrichtigungen.22-Button_funktioniert_nicht_mehr

The offending line comes from jquery.i18n.language.js, at the very end:

$.extend( $.i18n.languages, {
   default: language
} );

Obviously, IE 8 doesn't like the keyword default as unquoted object key. Upstream caused by https://github.com/wikimedia/jquery.i18n/commit/71c4219e72ac7754ec0c1ba8cc1814a1367a1057, ULS-extension by https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FUniversalLanguageSelector.git/05dd11fcb07e8851bb69739839a8cf748aaa6fef

Related Objects

Mentioned Here: T117849: jquery.i18n causes JavaScript error in IE 8, default is a reserved keyword

Event Timeline

Schnark created this task.Sep 12 2015, 7:36 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added a project: UniversalLanguageSelector.

Schnark subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2015, 7:36 AM

Schnark added a subscriber: Jdforrester-WMF.Sep 12 2015, 7:36 AM

Aklapper added a project: Browser-Support-Internet-Explorer.Sep 12 2015, 12:03 PM

Aklapper set Security to None.

See also, T117849. This affects older MediaWiki releases as new ones ship jquery.i18n in core (having the same issue).

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 11 2015, 8:50 AM

Danny_B moved this task from Unsorted to IE8 on the Browser-Support-Internet-Explorer board.Feb 14 2016, 5:20 PM

As far as I remember this was fixed, but now support for IE 8 is discontinued anyways.

https://github.com/wikimedia/jquery.i18n/blob/master/src/jquery.i18n.language.js

Poyekhali triaged this task as High priority.Apr 13 2016, 6:42 AM

Aklapper raised the priority of this task from High to Needs Triage.Apr 13 2016, 12:10 PM