Page MenuHomePhabricator

Math node updates rendering when ID field is typed into
Closed, ResolvedPublic1 Story Points

Description

The id attribute doesn't affect the rendering at all, so there's no need to update the rendering.

GeneratedContentNodes call #storeGeneratedContents which calls #getHashObject (inherited from ve.dm.Model), which calls its static namesake. This can be overriden to exclude the ID attribute.

Event Timeline

Esanders created this task.Sep 13 2015, 3:04 PM
Esanders claimed this task.
Esanders raised the priority of this task from to Low.
Esanders updated the task description. (Show Details)
Esanders added a subscriber: Esanders.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2015, 3:04 PM
Esanders reassigned this task from Esanders to Tchanders.Sep 13 2015, 10:24 PM
Esanders set Security to None.

Change 238167 had a related patch set uploaded (by Tchanders):
VisualEditor: Ignore id when getting hash object

https://gerrit.wikimedia.org/r/238167

Jdforrester-WMF closed this task as Resolved.Sep 14 2015, 10:37 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.