Page MenuHomePhabricator
Create Task
Maniphest T112599

Show the VE-MW welcome dialog to first-time users on mobile too
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
VE: Show welcome dialogmediawiki/extensions/MobileFrontendmaster+2 -0
Show welcome dialog on mobile toomediawiki/extensions/VisualEditormaster+102 -86
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 14 2015, 10:32 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Mobile.
Jdforrester-WMF added subscribers: Jdforrester-WMF, Krenair.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 10:32 PM
Jdforrester-WMF added a parent task: T94725: Make VisualEditor good enough for mobile tablet and phone default enablement.Sep 14 2015, 10:32 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.
Krenair added a comment.Feb 19 2016, 6:24 PM

Although this should theoretically be easy, the window does not appear to actually display anything when you open it using the existing temporary WindowManager code

Krenair claimed this task.Feb 19 2016, 6:47 PM
Krenair added a comment.Feb 19 2016, 6:52 PM

Also, we added support for switching to wikitext to that dialog... but mobile does it in a different way

• AlexMonk-WMF claimed this task.Feb 19 2016, 8:24 PM
• AlexMonk-WMF added a comment.EditedFeb 20 2016, 2:34 AM

Unfortunately some of the SET code is required to do that properly do that and it's set up by DesktopArticleTarget.init :/

• AlexMonk-WMF added a comment.Feb 20 2016, 2:39 AM

ve.init.mw.ArticleTarget.init.js anyone?

gerritbot subscribed.Feb 20 2016, 8:18 PM

Change 271994 had a related patch set uploaded (by Alex Monk):
Show welcome dialog on mobile too

https://gerrit.wikimedia.org/r/271994

gerritbot added a project: Patch-For-Review.Feb 20 2016, 8:18 PM
• AlexMonk-WMF added a comment.Feb 20 2016, 8:19 PM

I decided to avoid that issue by removing the switch button on mobile for now

gerritbot added a comment.Feb 20 2016, 8:43 PM

Change 272004 had a related patch set uploaded (by Alex Monk):
VE: Show welcome dialog

https://gerrit.wikimedia.org/r/272004

• AlexMonk-WMF subscribed.Feb 23 2016, 3:41 AM
• AlexMonk-WMF removed a subscriber: Krenair.Feb 23 2016, 3:44 AM
Jdforrester-WMF closed this task as Resolved.Feb 29 2016, 2:51 AM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Feb 29 2016, 3:02 AM

Change 271994 merged by jenkins-bot:
Show welcome dialog on mobile too

https://gerrit.wikimedia.org/r/271994

gerritbot added a comment.Feb 29 2016, 3:02 AM

Change 272004 merged by jenkins-bot:
VE: Show welcome dialog

https://gerrit.wikimedia.org/r/272004

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 29 2016, 4:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits