Page MenuHomePhabricator
Create Task
Maniphest T112961

Deprecated module classes show up in console
Closed, ResolvedPublic
Actions

Description

Visiting http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page you'll see lots of deprecated warnings in the console. Please update the require calls to use the correct module names. I suspect most of the issues are in Gather.

Details

SubjectRepoBranchLines +/-
Fix module deprecation warning in WatchListGatewaymediawiki/extensions/MobileFrontendmaster+1 -1
Get rid of deprecated module warningsmediawiki/extensions/Gathermaster+69 -69
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 17 2015, 8:38 PM
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Reading-Web-Sprint-56-Four Lions, Gather, good first task.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 8:38 PM
Jdlrobson moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 8:38 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.Sep 18 2015, 10:21 PM
Jdlrobson added subscribers: • bmansurov, • rmoen, phuedx, • jhobs.

@bmansurov @phuedx @jhobs @rmoen I've moved into sprint given that this is visible to other developers and I'm keen to get all usage of these modules deprecated asap.

• bmansurov added a comment.Sep 19 2015, 1:12 AM

There are patches for this already:
https://gerrit.wikimedia.org/r/#/c/239347/
https://gerrit.wikimedia.org/r/#/c/239348/

• bmansurov moved this task from To Do to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 19 2015, 1:13 AM
phuedx added a comment.Sep 21 2015, 8:46 AM

239347 has been merged already.

gerritbot subscribed.Sep 21 2015, 8:47 AM

Change 239348 had a related patch set uploaded (by Phuedx):
Get rid of deprecated module warnings

https://gerrit.wikimedia.org/r/239348

gerritbot added a project: Patch-For-Review.Sep 21 2015, 8:47 AM
phuedx assigned this task to Jdlrobson.Sep 21 2015, 8:52 AM
phuedx set Security to None.
phuedx reassigned this task from Jdlrobson to • bmansurov.Sep 21 2015, 2:05 PM

@bmansurov's patches caught all but four of 'em I think. I've submitted a follow-on patch for the four that were missed that I suspect we'll squash.

gerritbot added a comment.Sep 21 2015, 7:16 PM

Change 239348 merged by jenkins-bot:
Get rid of deprecated module warnings

https://gerrit.wikimedia.org/r/239348

• bmansurov mentioned this in rMEXT06b4d883d454: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Sep 21 2015, 7:16 PM
Jdlrobson mentioned this in rEGAT69d7617b7a35: Get rid of deprecated module warnings.Sep 21 2015, 7:17 PM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 21 2015, 7:53 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 21 2015, 8:00 PM
Jdlrobson closed this task as Resolved.Sep 21 2015, 9:04 PM

Looks good. Setup T113289

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.Sep 21 2015, 9:04 PM
gerritbot added a comment.Sep 22 2015, 2:31 PM

Change 240098 had a related patch set uploaded (by Phuedx):
Fix module deprecation warning in WatchListGateway

https://gerrit.wikimedia.org/r/240098

phuedx added a comment.Sep 22 2015, 2:32 PM

I spotted 240098 almost immediately after merging the patch that introduced it. Boo.

gerritbot added a comment.Sep 22 2015, 3:10 PM

Change 240098 merged by jenkins-bot:
Fix module deprecation warning in WatchListGateway

https://gerrit.wikimedia.org/r/240098

phuedx mentioned this in rMEXTc7286083e13d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 22 2015, 3:10 PM
phuedx mentioned this in rEMFR52f25973ea13: Fix module deprecation warning in WatchListGateway.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits