Page MenuHomePhabricator

Remove deprecated modules
Closed, ResolvedPublic

Description

In various place we do

M.define( 'foo' ).deprecate( 'moduleName' )

We should be able to safely remove all of calls to deprecate.

Event Timeline

Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2015, 9:04 PM

Hi, is this bug open, i will like to work on it.

Jdlrobson added subscribers: bmansurov, phuedx.

@D3r1ck01 go for it! I've assigned you to it. You can get help on this bug or by visiting us in #wikimedia-mobile on irc.freenode.org - it will be a great way for you to get acquainted with our codebase!

^ cc @bmansurov @phuedx

So does this mean functions without this should be put? Or what because i don't clearly understand the goal.

Change 240601 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules

https://gerrit.wikimedia.org/r/240601

Change 240601 merged by jenkins-bot:
Removing deprecated modules

https://gerrit.wikimedia.org/r/240601

Change 240603 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(3)

https://gerrit.wikimedia.org/r/240603

Change 240604 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(4)

https://gerrit.wikimedia.org/r/240604

Change 240607 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(5)

https://gerrit.wikimedia.org/r/240607

Change 240609 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(6)

https://gerrit.wikimedia.org/r/240609

Change 240611 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/240611

Change 240603 merged by jenkins-bot:
Removing deprecated modules(3)

https://gerrit.wikimedia.org/r/240603

Change 240607 merged by jenkins-bot:
Removing deprecated modules(5)

https://gerrit.wikimedia.org/r/240607

Change 240609 merged by jenkins-bot:
Removing deprecated modules(6)

https://gerrit.wikimedia.org/r/240609

https://gerrit.wikimedia.org/r/240604 needs rebasing and https://gerrit.wikimedia.org/r/#/c/240611/ indicates an update needs to happen in the Thanks extension before that can be merged but we're super close now!

Change 240604 abandoned by D3r1ck01:
Removing deprecated modules(4)

Reason:
nothing...

https://gerrit.wikimedia.org/r/240604

Change 241036 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/241036

Change 240611 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
nothing...

https://gerrit.wikimedia.org/r/240611

Change 241036 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
nothing...

https://gerrit.wikimedia.org/r/241036

Change 241036 restored by D3r1ck01:
Removing deprecated modules(7)

Reason:
to work on again.

https://gerrit.wikimedia.org/r/241036

Change 240611 restored by D3r1ck01:
Removing deprecated modules(7)

Reason:
to be done again.

https://gerrit.wikimedia.org/r/240611

Change 241036 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
mistakes.

https://gerrit.wikimedia.org/r/241036

As @D3r1ck01 notes in the commit message for 240611, the Thanks extension needs to be updated so that it doesn't use the 'toast' module.

Change 240611 merged by jenkins-bot:
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/240611

Change 241052 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(8)

https://gerrit.wikimedia.org/r/241052

Change 241052 merged by jenkins-bot:
Removing deprecated modules(8)

https://gerrit.wikimedia.org/r/241052

Change 241084 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(10)

https://gerrit.wikimedia.org/r/241084

Change 241480 had a related patch set uploaded (by Florianschmidtwelzow):
Use the new module name for eventlogging module

https://gerrit.wikimedia.org/r/241480

Change 241480 merged by jenkins-bot:
Use the new module name for eventlogging module

https://gerrit.wikimedia.org/r/241480

Change 241084 merged by jenkins-bot:
Removing deprecated modules(9)

https://gerrit.wikimedia.org/r/241084

Jdlrobson closed this task as Resolved.Sep 28 2015, 4:10 PM
Jdlrobson added a subscriber: Florian.

All done! Great work @D3r1ck01 thanks for the dedication to getting this done! :) Thanks @Florian for resolving the Thanks issue!