Page MenuHomePhabricator
Create Task
Maniphest T113289

Remove deprecated modules
Closed, ResolvedPublic
Actions

Description

In various place we do

M.define( 'foo' ).deprecate( 'moduleName' )

We should be able to safely remove all of calls to deprecate.

Details

SubjectRepoBranchLines +/-
Removing deprecated modules(9)mediawiki/extensions/MobileFrontendmaster+15 -25
Use the new module name for eventlogging modulemediawiki/extensions/Thanksmaster+1 -1
Removing deprecated modules(8)mediawiki/extensions/MobileFrontendmaster+4 -4
Removing deprecated modules(7)mediawiki/extensions/MobileFrontendmaster+10 -18
Removing deprecated modules(7)mediawiki/extensions/MobileFrontendmaster+1 -1
Removing deprecated modules(4)mediawiki/extensions/MobileFrontendmaster+50 -76
Removing deprecated modules(6)mediawiki/extensions/MobileFrontendmaster+24 -32
Removing deprecated modules(3)mediawiki/extensions/MobileFrontendmaster+6 -12
Removing deprecated modules(5)mediawiki/extensions/MobileFrontendmaster+8 -12
Removing deprecated modulesmediawiki/extensions/MobileFrontendmaster+7 -12
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 21 2015, 9:04 PM
Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: MobileFrontend, good first task.
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2015, 9:04 PM
Jdlrobson mentioned this in T112961: Deprecated module classes show up in console.Sep 21 2015, 9:04 PM
xSavitar subscribed.Sep 22 2015, 11:49 AM

Hi, is this bug open, i will like to work on it.

Jdlrobson assigned this task to xSavitar.Sep 22 2015, 3:46 PM
Jdlrobson added subscribers: • bmansurov, phuedx.

@D3r1ck01 go for it! I've assigned you to it. You can get help on this bug or by visiting us in #wikimedia-mobile on irc.freenode.org - it will be a great way for you to get acquainted with our codebase!

^ cc @bmansurov @phuedx

xSavitar added a comment.Sep 23 2015, 6:55 PM

So does this mean functions without this should be put? Or what because i don't clearly understand the goal.

gerritbot subscribed.Sep 23 2015, 10:15 PM

Change 240601 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules

https://gerrit.wikimedia.org/r/240601

gerritbot added a project: Patch-For-Review.Sep 23 2015, 10:15 PM
gerritbot added a comment.Sep 23 2015, 10:44 PM

Change 240601 merged by jenkins-bot:
Removing deprecated modules

https://gerrit.wikimedia.org/r/240601

xSavitar mentioned this in rEMFR18e4022d847c: Removing deprecated modules.Sep 23 2015, 10:45 PM
gerritbot added a comment.Sep 23 2015, 10:45 PM

Change 240603 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(3)

https://gerrit.wikimedia.org/r/240603

xSavitar mentioned this in rMEXT725aac70ea50: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 23 2015, 10:45 PM
gerritbot added a comment.Sep 23 2015, 10:52 PM

Change 240604 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(4)

https://gerrit.wikimedia.org/r/240604

gerritbot added a comment.Sep 23 2015, 11:07 PM

Change 240607 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(5)

https://gerrit.wikimedia.org/r/240607

gerritbot added a comment.Sep 23 2015, 11:21 PM

Change 240609 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(6)

https://gerrit.wikimedia.org/r/240609

gerritbot added a comment.Sep 23 2015, 11:36 PM

Change 240611 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/240611

xSavitar mentioned this in rEMFR90079cf2071a: Removing deprecated modules(2).Sep 24 2015, 8:13 PM
Diffusion mentioned this in rMEXT731fd3f28a0f: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 24 2015, 8:13 PM
gerritbot added a comment.Sep 24 2015, 8:19 PM

Change 240603 merged by jenkins-bot:
Removing deprecated modules(3)

https://gerrit.wikimedia.org/r/240603

gerritbot added a comment.Sep 24 2015, 8:19 PM

Change 240607 merged by jenkins-bot:
Removing deprecated modules(5)

https://gerrit.wikimedia.org/r/240607

gerritbot added a comment.Sep 24 2015, 8:19 PM

Change 240609 merged by jenkins-bot:
Removing deprecated modules(6)

https://gerrit.wikimedia.org/r/240609

Diffusion mentioned this in rMEXTc580b80b0fb7: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 24 2015, 8:20 PM
Diffusion mentioned this in rMEXTbb5f685f3420: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Diffusion mentioned this in rMEXT7b3c36d7340e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
xSavitar mentioned this in rEMFR052e7c2ac67c: Removing deprecated modules(3).Sep 24 2015, 8:20 PM
xSavitar mentioned this in rEMFR55a48f952c6d: Removing deprecated modules(5).
xSavitar mentioned this in rEMFR4fe420eebe32: Removing deprecated modules(6).
Jdlrobson added a comment.Sep 24 2015, 8:48 PM

https://gerrit.wikimedia.org/r/240604 needs rebasing and https://gerrit.wikimedia.org/r/#/c/240611/ indicates an update needs to happen in the Thanks extension before that can be merged but we're super close now!

gerritbot added a comment.Sep 25 2015, 1:47 PM

Change 240604 abandoned by D3r1ck01:
Removing deprecated modules(4)

Reason:
nothing...

https://gerrit.wikimedia.org/r/240604

gerritbot added a comment.Sep 25 2015, 1:58 PM

Change 241036 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/241036

gerritbot added a comment.Sep 25 2015, 2:03 PM

Change 240611 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
nothing...

https://gerrit.wikimedia.org/r/240611

gerritbot added a comment.Sep 25 2015, 2:04 PM

Change 241036 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
nothing...

https://gerrit.wikimedia.org/r/241036

gerritbot added a comment.Sep 25 2015, 2:05 PM

Change 241036 restored by D3r1ck01:
Removing deprecated modules(7)

Reason:
to work on again.

https://gerrit.wikimedia.org/r/241036

gerritbot added a comment.Sep 25 2015, 2:11 PM

Change 240611 restored by D3r1ck01:
Removing deprecated modules(7)

Reason:
to be done again.

https://gerrit.wikimedia.org/r/240611

gerritbot added a comment.Sep 25 2015, 2:12 PM

Change 241036 abandoned by D3r1ck01:
Removing deprecated modules(7)

Reason:
mistakes.

https://gerrit.wikimedia.org/r/241036

phuedx added a comment.Sep 25 2015, 2:41 PM

As @D3r1ck01 notes in the commit message for 240611, the Thanks extension needs to be updated so that it doesn't use the 'toast' module.

gerritbot added a comment.Sep 25 2015, 2:42 PM

Change 240611 merged by jenkins-bot:
Removing deprecated modules(7)

https://gerrit.wikimedia.org/r/240611

xSavitar mentioned this in rMEXTbfff6adb3495: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 25 2015, 2:42 PM
xSavitar mentioned this in rEMFR2507d0bf1e0d: Removing deprecated modules(7).
gerritbot added a comment.Sep 25 2015, 3:01 PM

Change 241052 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(8)

https://gerrit.wikimedia.org/r/241052

gerritbot added a comment.Sep 25 2015, 4:30 PM

Change 241052 merged by jenkins-bot:
Removing deprecated modules(8)

https://gerrit.wikimedia.org/r/241052

xSavitar mentioned this in rEMFR951048bfd783: Removing deprecated modules(8).Sep 25 2015, 4:30 PM
Diffusion mentioned this in rMEXT7ed1265bb292: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 25 2015, 4:30 PM
gerritbot added a comment.Sep 25 2015, 5:11 PM

Change 241084 had a related patch set uploaded (by D3r1ck01):
Removing deprecated modules(10)

https://gerrit.wikimedia.org/r/241084

gerritbot added a comment.Sep 26 2015, 11:23 PM

Change 241480 had a related patch set uploaded (by Florianschmidtwelzow):
Use the new module name for eventlogging module

https://gerrit.wikimedia.org/r/241480

gerritbot added a comment.Sep 28 2015, 4:03 PM

Change 241480 merged by jenkins-bot:
Use the new module name for eventlogging module

https://gerrit.wikimedia.org/r/241480

Florian mentioned this in rMEXT7e9626daa447: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….Sep 28 2015, 4:03 PM
gerritbot added a comment.Sep 28 2015, 4:06 PM

Change 241084 merged by jenkins-bot:
Removing deprecated modules(9)

https://gerrit.wikimedia.org/r/241084

phuedx mentioned this in rETHAaad7e245fa3a: Use the new module name for eventlogging module.Sep 28 2015, 4:06 PM
xSavitar mentioned this in rMEXT2c260fdd0929: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 28 2015, 4:06 PM
Jdlrobson mentioned this in rEMFRded8dab91184: Removing deprecated modules(9).Sep 28 2015, 4:06 PM
Jdlrobson closed this task as Resolved.Sep 28 2015, 4:10 PM
Jdlrobson added a subscriber: Florian.

All done! Great work @d3r1ck01 thanks for the dedication to getting this done! :) Thanks @Florian for resolving the Thanks issue!

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 8:02 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
Jdlrobson mentioned this in T114599: Missing watchlist stars, search suggestions and more on English Wikipedia mobile site.Oct 5 2015, 8:35 PM
• MZMcBride subscribed.Oct 6 2015, 1:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits