Page MenuHomePhabricator
Create Task
Maniphest T113454

Cannot remove invalid members from cohort
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Firefox-only bug

When trying to remove an invalid user from a cohort nothing happens. The console reports "event is not defined" on line 63 of cohortMembership.js

To reproduce:

  1. Select a cohort (with at least one invalid/partially valid member)
  2. View members
  3. Filter by invalid users
  4. Select remove invalid or remove

Details

SubjectRepoBranchLines +/-
Fix js error in cohort member removalanalytics/wikimetricsmaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Sep 23 2015, 8:20 AM
Lokal_Profil raised the priority of this task from to Needs Triage.
Lokal_Profil updated the task description. (Show Details)
Lokal_Profil added projects: Analytics-Engineering, Analytics-Wikimetrics.
Lokal_Profil subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 8:20 AM
Lokal_Profil mentioned this in T115334: Statistic about Wiki Loves Monuments for 2015.Oct 15 2015, 1:54 PM
Milimetric moved this task from Incoming to Backlog on the Analytics-Engineering board.Dec 10 2015, 6:27 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 10 2015, 6:27 PM
• ggellerman edited projects, added Analytics; removed Analytics-Engineering.Jan 12 2016, 7:38 PM
Milimetric moved this task from Incoming to Event Platform on the Analytics board.Jan 12 2016, 7:38 PM
Milimetric closed this task as Invalid.Aug 22 2016, 3:50 PM
Milimetric subscribed.

It actually works in production, but it's really slow (this is due to the database having too many users, we'll try and clean that up and maybe add some indices).

Lokal_Profil reopened this task as Open.Aug 22 2016, 4:27 PM

I still get the "event is not defined" error in the js (running Firefox 48.0 on Ubuntu)

Milimetric added a comment.Aug 23 2016, 9:53 PM

do you mind trying it on Chrome to see if that's the issue? It seems to be fine for me on both. What version of Ubuntu?

Lokal_Profil added a comment.Aug 25 2016, 12:51 PM

Tried it on Chrome now. It works there so seems to be a Firefox specific bug.

Running Ubuntu 14.04

Lokal_Profil added a project: Browser-Support-Firefox.Aug 25 2016, 12:51 PM
Milimetric claimed this task.Aug 25 2016, 3:10 PM
Milimetric triaged this task as Medium priority.
Milimetric edited projects, added Analytics-Kanban; removed Analytics.
Milimetric updated the task description. (Show Details)
Milimetric set the point value for this task to 3.Aug 25 2016, 4:55 PM
Milimetric moved this task from Next Up to In Progress on the Analytics-Kanban board.Aug 29 2016, 1:59 PM
gerritbot subscribed.Aug 29 2016, 2:23 PM

Change 307291 had a related patch set uploaded (by Milimetric):
Fix js error in cohort member removal

https://gerrit.wikimedia.org/r/307291

gerritbot added a project: Patch-For-Review.Aug 29 2016, 2:23 PM

Change 307291 merged by Milimetric:
Fix js error in cohort member removal

https://gerrit.wikimedia.org/r/307291

Milimetric moved this task from In Progress to In Code Review on the Analytics-Kanban board.Aug 29 2016, 2:24 PM
Milimetric moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.
Milimetric moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Aug 29 2016, 2:29 PM
• Nuria closed this task as Resolved.Aug 29 2016, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits