Maniphest T113764

Use new editor for undo pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 25 2015, 4:55 PM

Tags

Referenced Files

	F2683831: Screen Shot 2015-10-09 at 5.12.31 PM.png
	Oct 10 2015, 12:19 AM

	F2683825: Screen Shot 2015-10-09 at 5.11.57 PM.png
	Oct 10 2015, 12:19 AM

	F2634759: Screen Shot 2015-09-25 at 9.48.06 AM.png
	Sep 25 2015, 4:55 PM

	F2634757: Screen Shot 2015-09-24 at 4.48.03 PM.png
	Sep 25 2015, 4:55 PM

Subscribers

Description

Original report:

View history of any Flow page - click on 'undo' action.

The page, e.g

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Sndry65kegyo49kb&action=undo-edit-post&topic_startId=spjwujzdrfq00h7c&topic_endId=spjx4zjcqexdwaoo
is displayed and there is no editing icons in CE area unless you click in it (expected behavior?).

Screen Shot 2015-09-24 at 4.48.03 PM.png (456×727 px, 70 KB)

Click in the CE area and old-style wikitext edit mode icon is displayed.

Screen Shot 2015-09-25 at 9.48.06 AM.png (609×749 px, 81 KB)

Note: Switching to VE - the new wikitext editor icon is displayed.

Details

	Subject	Repo	Branch	Lines +/-
	Use the new editor when undoing edits	mediawiki/extensions/Flow	master	+84 -0

Customize query in gerrit

Related Objects

Mentioned Here: T116085: History: 'undo' for topic summary still uses the old editor system (has the old-style icon)

Event Timeline

Etonkovidova created this task.Sep 25 2015, 4:55 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2015, 4:55 PM

• Mattflaschen-WMF moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.Sep 25 2015, 5:53 PM

• Mattflaschen-WMF renamed this task from Old style wikitext icon is displayed on undo-edit-post pages to Use new editor for undo pages.Sep 25 2015, 5:57 PM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF set Security to None.

• DannyH triaged this task as Medium priority.Sep 28 2015, 5:43 PM

• DannyH subscribed.

• DannyH unsubscribed.Oct 5 2015, 10:47 PM

Mooeypoo claimed this task.Oct 7 2015, 5:35 PM

Mooeypoo moved this task from Ready for pickup to In Development on the Collaboration-Team-Archive-2015-2016 board.

Change 244369 had a related patch set uploaded (by Mooeypoo):
Use the new editor when undoing edits

https://gerrit.wikimedia.org/r/244369

gerritbot added a project: Patch-For-Review.Oct 7 2015, 10:50 PM

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 7 2015, 10:50 PM

Catrope moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Oct 8 2015, 6:51 PM

Change 244369 merged by jenkins-bot:
Use the new editor when undoing edits

https://gerrit.wikimedia.org/r/244369

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 9 2015, 7:00 AM

Catrope moved this task from Code Review Started to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 9 2015, 7:47 PM

Checked in betalabs - from 'View history' 'undo' action will be displayed with new wikitext icon for

edit comment
edit description

However, 'undo' for topic summary still has the old-style icon filed as a separate bug: T116085 "History: 'undo' for topic summary still has the old-style icon":
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET1&action=history - click on 'undo' for "edited topic summary on Sep09-02 modified..."

Screen Shot 2015-10-09 at 5.12.31 PM.png (556×862 px, 65 KB)

Etonkovidova moved this task from QA Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Oct 10 2015, 12:21 AM

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 12 2015, 8:31 PM

Catrope moved this task from Needs Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Oct 13 2015, 9:18 PM

Mooeypoo moved this task from In Development to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 19 2015, 10:51 PM

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 20 2015, 9:11 PM

Catrope closed this task as Resolved.Nov 22 2015, 10:54 PM

Catrope subscribed.