Page MenuHomePhabricator
Create Task
Maniphest T114144

Guided tour: clicking Back button displays an error in Console
Closed, ResolvedPublic
Actions

Description

[GuidedTourButtonClick] Value "back" for property "action" is not one of ["next","okay","end","internalLink","externalLink","custom"]

mw.log.log.error	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:156
(anonymous function)	@	VM1130:404
handler	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:155
jQuery.Callbacks.fire	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:45
jQuery.Callbacks.self.fireWith	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:46
jQuery.Callbacks.self.fire	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:46
mw.track	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:155
mw.loader.implement.mw.eventLog.prepare	@	VM1130:402
mw.loader.implement.mw.eventLog.logEvent	@	VM1130:403
mw.loader.implement.EventLogger.log	@	VM1130:417
mw.loader.implement.Step.getActionButton.button.onclick	@	VM1130:421
mw.loader.implement.mediaWiki.libs.guiders.guiders._makeButtonListener	@	VM1130:388
jQuery.event.dispatch	@	load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=c54hDTto:65
jQuery.event.add.elemData.handle

Details

SubjectRepoBranchLines +/-
Fix back button loggingmediawiki/extensions/GuidedTourwmf/1.27.0-wmf.1+1 -1
Fix back button loggingmediawiki/extensions/GuidedTourwmf/1.26wmf24+1 -1
Fix back button loggingmediawiki/extensions/GuidedTourmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 29 2015, 5:28 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: Collaboration-Team-Archive-2015-2016, StructuredDiscussions.
Etonkovidova added subscribers: Aklapper, Etonkovidova.
• Mattflaschen-WMF claimed this task.Sep 29 2015, 5:48 PM
• Mattflaschen-WMF moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
• Mattflaschen-WMF edited projects, added MediaWiki-extensions-GuidedTour; removed StructuredDiscussions.
• Mattflaschen-WMF set Security to None.
gerritbot subscribed.Sep 29 2015, 6:54 PM

Change 242238 had a related patch set uploaded (by Mattflaschen):
Fix back button logging

https://gerrit.wikimedia.org/r/242238

gerritbot added a project: Patch-For-Review.Sep 29 2015, 6:54 PM
• Mattflaschen-WMF moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 29 2015, 6:55 PM
gerritbot added a comment.Sep 29 2015, 10:08 PM

Change 242238 merged by jenkins-bot:
Fix back button logging

https://gerrit.wikimedia.org/r/242238

Diffusion mentioned this in rMEXT54e1543c6c9d: Updated mediawiki/extensions Project: mediawiki/extensions/GuidedTour….Sep 29 2015, 10:09 PM
• Mattflaschen-WMF mentioned this in rEGTOb646ab08f610: Fix back button logging.Sep 29 2015, 10:09 PM
gerritbot added a comment.Sep 29 2015, 10:44 PM

Change 242384 had a related patch set uploaded (by Mattflaschen):
Fix back button logging

https://gerrit.wikimedia.org/r/242384

gerritbot added a comment.Sep 29 2015, 10:45 PM

Change 242387 had a related patch set uploaded (by Mattflaschen):
Fix back button logging

https://gerrit.wikimedia.org/r/242387

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 11:02 PM
gerritbot added a comment.Sep 29 2015, 11:10 PM

Change 242384 merged by jenkins-bot:
Fix back button logging

https://gerrit.wikimedia.org/r/242384

gerritbot added a comment.Sep 29 2015, 11:10 PM

Change 242387 merged by jenkins-bot:
Fix back button logging

https://gerrit.wikimedia.org/r/242387

• Mattflaschen-WMF mentioned this in rMW7f9ec7124466: Updated mediawiki/core Project: mediawiki/extensions/GuidedTour….Sep 29 2015, 11:12 PM
• Mattflaschen-WMF mentioned this in rMW754bd297fa99: Updated mediawiki/core Project: mediawiki/extensions/GuidedTour….
• Mattflaschen-WMF mentioned this in rEGTO7ff008ac0126: Fix back button logging.
• Mattflaschen-WMF mentioned this in rEGTOef2cab5e7e82: Fix back button logging.
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 12:04 AM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:47 AM
Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:56 AM
Etonkovidova added a comment.Sep 30 2015, 4:09 PM

Checked in betalabs.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 4:09 PM
• DannyH closed this task as Resolved.Sep 30 2015, 4:57 PM
• DannyH subscribed.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Oct 1 2015, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL