FF 34.0.5, linux
Sad! I was thrilled to mouse through the VisualEditor -> Insert Media -> Upload dialog, but it seemed to hang before I even pressed Save. The barbershop bar has been chugging for a few minutes now. This is a very small png file, 39kB.
From the JS console,
"JavaScript parse error: Parse error: Unexpected token; token 3 expected in file 'MediaWiki:Gadget-ajaxrecentchanges.js' on line 100"
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mediawiki.Upload: Don't choke on nameless or dateless files | mediawiki/core | master | +7 -1 |
Trying another time, I get the first error, then a second one:
Error: Filename not included in file data.
Also, here's a stack trace from the first error:
mw.log</log.error() load.php:156 <anonymous> load.php:56 execute/runScript/<() load.php:162 jQuery.Callbacks/fire() load.php:45 jQuery.Callbacks/self.add() load.php:45 .Deferred/promise.always() load.php:46 execute/runScript()
If you got "Error: Filename not included in file data.", then that's not from the gadget, but from our code.
Can you still reproduce? What is the actual file name of the file you're trying to upload?
Hmm… any chance that your file was last modified on Thursday, 1 January 1970, or that Firefox would think so?
Change 247740 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.Upload: Don't choke on nameless or dateless files
Change 247740 merged by jenkins-bot:
mediawiki.Upload: Don't choke on nameless or dateless files