Page MenuHomePhabricator

Insert media dialog hangs during image upload
Closed, ResolvedPublic1 Story Points

Description

FF 34.0.5, linux

Sad! I was thrilled to mouse through the VisualEditor -> Insert Media -> Upload dialog, but it seemed to hang before I even pressed Save. The barbershop bar has been chugging for a few minutes now. This is a very small png file, 39kB.

From the JS console,

"JavaScript parse error: Parse error: Unexpected token; token 3 expected in file 'MediaWiki:Gadget-ajaxrecentchanges.js' on line 100"

Event Timeline

awight created this task.Oct 20 2015, 6:56 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a subscriber: awight.
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 20 2015, 6:56 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
awight updated the task description. (Show Details)Oct 20 2015, 6:56 PM
awight set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 20 2015, 6:56 PM

Trying another time, I get the first error, then a second one:

Error: Filename not included in file data.

Also, here's a stack trace from the first error:

mw.log</log.error() load.php:156
<anonymous> load.php:56
execute/runScript/<() load.php:162
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/self.add() load.php:45
.Deferred/promise.always() load.php:46
execute/runScript()
Jdforrester-WMF closed this task as Invalid.Oct 20 2015, 7:07 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Gadget bugs aren't tracked in Phab.

matmarex reopened this task as Open.Oct 20 2015, 9:29 PM
matmarex added a subscriber: matmarex.

If you got "Error: Filename not included in file data.", then that's not from the gadget, but from our code.

Can you still reproduce? What is the actual file name of the file you're trying to upload?

Hmm… any chance that your file was last modified on Thursday, 1 January 1970, or that Firefox would think so?

matmarex claimed this task.Oct 20 2015, 9:56 PM

Change 247740 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.Upload: Don't choke on nameless or dateless files

https://gerrit.wikimedia.org/r/247740

Jdforrester-WMF closed this task as Resolved.Oct 20 2015, 10:16 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.

Change 247740 merged by jenkins-bot:
mediawiki.Upload: Don't choke on nameless or dateless files

https://gerrit.wikimedia.org/r/247740