Page MenuHomePhabricator

Total proposals received on Report by reviewer page should exclude abandoned proposals
Open, MediumPublic

Description

Currently the number shown is inclusive of abandoned proposals.

Details

Event Timeline

Niharika created this task.Oct 22 2015, 5:19 AM
Niharika raised the priority of this task from to Medium.
Niharika updated the task description. (Show Details)
Niharika moved this task to Backlog on the Wikimedia-IEG-grant-review board.
Niharika added a subscriber: Niharika.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2015, 5:19 AM

I want to work on this issue. Could you please help me reproduce this? I checked the aggregated scores page which doesn't show abandoned proposals.

I want to work on this issue. Could you please help me reproduce this? I checked the aggregated scores page which doesn't show abandoned proposals.

Ah, that's not the right page. Go to Admin > Manage Campaigns > Report by Reviewer. (Make sure you have some reviewed proposals first)

So according to this ticket, the "Total proposals received" there includes abandoned proposals. Can you verify if that's still the case?

Nehajha added a comment.EditedOct 17 2017, 1:46 PM

Ah, that's not the right page. Go to Admin > Manage Campaigns > Report by Reviewer. (Make sure you have some reviewed proposals first)

Thanks for the steps.

Can you verify if that's still the case?

Yes. "Total proposals received" and "Proposals reviewed" both include abandoned proposals.
This is due to the fact that the queries do not have conditions for the status of proposals.
If a proposal is reviewed and then abandoned, it still shows up in "Link to proposals reviewed". I don't think this is desired behavior. Should we fix that as well?

Can you verify if that's still the case?

Yes. "Total proposals received" and "Proposals reviewed" both include abandoned proposals.
This is due to the fact that the queries do not have conditions for the status of proposals.

Correct. We should fix this.

If a proposal is reviewed and then abandoned, it still shows up in "Link to proposals reviewed". I don't think this is desired behavior. Should we fix that as well?

I'm unsure if the right thing to do would be to completely remove the proposal from the list or to show some kind of indication that the proposal has been abandoned.
A common use case for abandoning proposals is when participants submit multiple proposals. Reviewers might start reviewing proposals but when one later gets abandoned, they might want to copy over that data to the other proposal which is yet unreviewed but has same content. This is not a very common use case but it might exist. Create a ticket for this and we'll discuss it afterwards. Not a part of this ticket.