Page MenuHomePhabricator

Update client IP in webrequest table to use IP [5 pts] {hawk}
Closed, ResolvedPublic

Description

clientIp is now computed from varnish and sent as IP. We should add this to webrequest and remove our client Ip calculations when we refine data.

https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/modules/varnish/templates/vcl/wikimedia.vcl.erb;987c66c3bad48fc93616be907527d58302a7aa2b$456

Event Timeline

Nuria assigned this task to Ottomata.
Nuria raised the priority of this task from to Needs Triage.
Nuria updated the task description. (Show Details)
Nuria added a subscriber: Nuria.
Milimetric triaged this task as Medium priority.Nov 19 2015, 5:52 PM
Milimetric moved this task from Incoming to Prioritized on the Analytics-Backlog board.
JAllemandou renamed this task from Add client IP to webrequest tables to Update client IP in webrequest table to use IP [5 pts] {hawk}.Dec 2 2015, 6:16 PM
JAllemandou claimed this task.
JAllemandou updated the task description. (Show Details)
JAllemandou edited projects, added Analytics-Kanban; removed Analytics-Backlog.
JAllemandou moved this task from Next Up to In Code Review on the Analytics-Kanban board.

Tested wiht hive: Over a few hours, there are only a very small amount of requests on which the client IP sent by varnish differs from the one computed on the cluster.

@BBlack reviewed those diffs, and the IP sent by varnish is actually a better approximation of the real client IP than computed on the cluster.

We should merge the code and deploy whenever.