Update client IP in webrequest table to use IP [5 pts] {hawk}
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Nuria
	Oct 27 2015, 4:10 PM

Description

clientIp is now computed from varnish and sent as IP. We should add this to webrequest and remove our client Ip calculations when we refine data.

https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/modules/varnish/templates/vcl/wikimedia.vcl.erb;987c66c3bad48fc93616be907527d58302a7aa2b$456

Related Objects

Duplicates Merged Here: T120105: Remove client_ip computation from refine
T118557: Replace Analytics XFF/client.ip data with X-Client-IP

Event Timeline

• Nuria created this task.Oct 27 2015, 4:10 PM

• Nuria assigned this task to Ottomata.

• Nuria raised the priority of this task from to Needs Triage.

• Nuria updated the task description. (Show Details)

• Nuria added projects: Analytics-Backlog, Analytics-Clusters.

• Nuria subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 4:10 PM

• Nuria added a project: good first task.Nov 19 2015, 5:52 PM

• Nuria set Security to None.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 19 2015, 5:52 PM

Milimetric triaged this task as Medium priority.Nov 19 2015, 5:52 PM

Milimetric moved this task from Incoming to Prioritized on the Analytics-Backlog board.

JAllemandou renamed this task from Add client IP to webrequest tables to Update client IP in webrequest table to use IP [5 pts] {hawk}.Dec 2 2015, 6:16 PM

JAllemandou claimed this task.

JAllemandou updated the task description. (Show Details)

JAllemandou edited projects, added Analytics-Kanban; removed Analytics-Backlog.

JAllemandou moved this task from Next Up to In Code Review on the Analytics-Kanban board.

Tested wiht hive: Over a few hours, there are only a very small amount of requests on which the client IP sent by varnish differs from the one computed on the cluster.

@BBlack reviewed those diffs, and the IP sent by varnish is actually a better approximation of the real client IP than computed on the cluster.

We should merge the code and deploy whenever.

JAllemandou moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Dec 3 2015, 9:56 AM

Milimetric merged a task: T120105: Remove client_ip computation from refine .Dec 3 2015, 6:10 PM

Milimetric added a subscriber: JAllemandou.

Milimetric merged a task: T118557: Replace Analytics XFF/client.ip data with X-Client-IP.Dec 7 2015, 6:00 PM

Milimetric added subscribers: leila, gerritbot, faidon, Ottomata.

JAllemandou moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Dec 18 2015, 5:08 PM

• Nuria closed this task as Resolved.Dec 21 2015, 5:03 PM