Page MenuHomePhabricator
Create Task
Maniphest T117625

Mirror unmerged changes in Diffusion from Gerrit
Closed, DuplicatePublic
Actions

Description

When uploading patches to gerrit, git.wikimedia.org clones the patch it dosent merge it into master branch or which ever branch because the patch hasent been code reviewed but phabricator should do the same since gitblit is deprecated on Wikimedia.

Steps to reproduce**

  • Then click on any open patches.
  • There is a link that says gitblit.

Actual results

  • The gitblit link only takes you to gitblit since it clones the patch but dosent merge it.

Expected results

  • There should be a phabricator link that phabricator should clone but shoulden merge until code reviewed.

Event Timeline

Paladox created this task.Nov 3 2015, 11:44 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: Phabricator.
Paladox subscribed.
Restricted Application added subscribers: StudiesWorld, Steinsplitter, scfc, Aklapper. · View Herald TranscriptNov 3 2015, 11:44 PM
Negative24 subscribed.Nov 4 2015, 12:20 AM
greg edited projects, added Diffusion; removed Phabricator.Nov 4 2015, 12:28 AM
greg set Security to None.
Aklapper added a comment.Nov 4 2015, 9:31 AM

Why? Please provide a usecase describing what you want to accomplish.

git.wikimedia.org clones the patch

I have no idea what that means. :(

Paladox added a comment.Nov 4 2015, 10:32 AM

Well use case is a user wants to view what the whole file looks like or wants to look what other files look like with that file.

and also it clones the patches ones that aren't merged yet such as https://gerrit.wikimedia.org/r/#/c/250007/ if you click gitblit it will take you to the diff for the patch.

Aklapper added a comment.Nov 4 2015, 11:17 AM

How is this related to Diffusion and its codebase? As we plan to kill Gerrit anyway.

Paladox added a comment.Nov 4 2015, 11:20 AM

Well gerrit is killed yet and gitblit is being killed and phabricator is recommended to be used instead. And since gitblit Is currently broken phabricator should do what gitblit was doing cloning patches.

Negative24 added a comment.Nov 4 2015, 2:31 PM

@Paladox Diffusion already mirrors all of the repositories. Are you wanting it to mirror unmerged patches as well?

Paladox added a comment.Nov 4 2015, 2:34 PM

Yes.

greg renamed this task from When uploading patches to gerrit phabricator should also download the patches to Mirror unmerged changes in Diffusion from Gerrit.Nov 4 2015, 7:41 PM
greg triaged this task as Low priority.
greg added a project: Gitblit-Deprecate.
• demon closed this task as a duplicate of T89940: Replicate open patchsets to diffusion.Nov 4 2015, 8:23 PM
• demon moved this task from To Triage to Done on the Gitblit-Deprecate board.Jan 13 2016, 9:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL