Page MenuHomePhabricator

Editing post using nojs URL with JS enabled is broken
Closed, ResolvedPublic

Description

Go to a Flow post, middle-click "Edit". On the page that loads next, the editor stays in a pending state forever. There are no errors in the console.

Event Timeline

Catrope raised the priority of this task from to Unbreak Now!.
Catrope updated the task description. (Show Details)
Catrope added a subscriber: Catrope.

Change 251547 had a related patch set uploaded (by Catrope):
Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path

https://gerrit.wikimedia.org/r/251547

Change 251547 merged by jenkins-bot:
Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path

https://gerrit.wikimedia.org/r/251547

Change 251560 had a related patch set uploaded (by Catrope):
Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path

https://gerrit.wikimedia.org/r/251560

Change 251560 merged by jenkins-bot:
Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path

https://gerrit.wikimedia.org/r/251560

Checked in betalabs.

  1. After right-clicking the menu gets stuck - a user needs to actually select one of the menu item to close it. As a result, overlapping menus may be displayed:

e.g.

Screen Shot 2015-11-11 at 2.04.50 PM.png (376×685 px, 48 KB)

Screen Shot 2015-11-11 at 2.17.32 PM.png (515×942 px, 66 KB)

  1. Filed T118425: 'Edit title' in a different browser tab results in Error - related to this issue?