Half a megabyte of JavaScript / CSS loading on view pages
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On the main page of enwiki while logged in, I get:

oojs-ui	227.5 kB
oojs-ui.styles.icons	128.6 kB
oojs-ui.styles	95.5 kB
oojs-ui.styles.icons-editing-core	27.9 kB
oojs-ui.styles.indicators	24.8 kB

@matmarex was able to pinpoint the cause -- VE and its 'ext.visualEditor.switching' module.
Regression introduced in rEVEDb550323b534b: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit.

Details

	Subject	Repo	Branch	Lines +/-
	Only load switching module (depending on OOUI etc.) on edit pages	mediawiki/extensions/VisualEditor	wmf/1.27.0-wmf.5	+13 -11
	Only load switching module (depending on OOUI etc.) on edit pages	mediawiki/extensions/VisualEditor	master	+15 -12

Customize query in gerrit

Related Objects

Mentioned In: T112401: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views
Mentioned Here: T113681: Split oojs-ui module into smaller ones
T125292: Optimize how we load OOUI in MediaWiki
rEVEDb550323b534b: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit
T112401: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views

Event Timeline

ori created this task.Nov 7 2015, 7:06 PM

ori assigned this task to Krenair.

ori raised the priority of this task from to High.

ori updated the task description. (Show Details)

ori added projects: VisualEditor, Performance Issue.

ori added subscribers: ori, matmarex.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2015, 7:06 PM

ori mentioned this in T112401: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views.Nov 7 2015, 7:07 PM

Change 251736 had a related patch set uploaded (by Alex Monk):
Only load switching module (depending on OOUI etc.) on edit pages

https://gerrit.wikimedia.org/r/251736

gerritbot added a project: Patch-For-Review.Nov 7 2015, 7:10 PM

Krenair added a project: VisualEditor-MediaWiki.Nov 7 2015, 7:12 PM

Change 251737 had a related patch set uploaded (by Alex Monk):
Only load switching module (depending on OOUI etc.) on edit pages

https://gerrit.wikimedia.org/r/251737

Change 251736 merged by jenkins-bot:
Only load switching module (depending on OOUI etc.) on edit pages

https://gerrit.wikimedia.org/r/251736

Change 251737 merged by jenkins-bot:
Only load switching module (depending on OOUI etc.) on edit pages

https://gerrit.wikimedia.org/r/251737

Nemo_bis subscribed.Nov 7 2015, 7:53 PM

This was deployed, but I'm having trouble confirming that it fixed the issue. Please check.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)), MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 7 2015, 8:00 PM

krenair@tin:/srv/mediawiki-staging (master)$ echo 'https://www.wikimedia.org/static/1.27.0-wmf.5/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js' | mwscript purgeList.php
Purging 1 urls
Done!
krenair@tin:/srv/mediawiki-staging (master)$

And now it seems to only get loaded on edit pages.

• MZMcBride subscribed.Nov 7 2015, 10:21 PM

He7d3r subscribed.Nov 8 2015, 10:45 AM

• Elitre subscribed.Nov 9 2015, 12:27 PM

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.Nov 9 2015, 4:53 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

MGChecker subscribed.Nov 9 2015, 5:46 PM

(For anybody browsing historical bugs, we're now working to slim down OOjs UI so that loading it on all pages is not a catastrophic performance regression. See T113681 and T125292 for details and progress.)

Half a megabyte of JavaScript / CSS loading on view pagesClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Half a megabyte of JavaScript / CSS loading on view pages
Closed, ResolvedPublic1 Estimated Story Points
Actions