Page MenuHomePhabricator
Create Task
Maniphest T118873

Special:Notifications should use UserNotLoggedIn and auto-redirect to login page instead of custom error message
Closed, ResolvedPublic
Actions

Description

Special:Notifications should throw the UserNotLoggedIn exception which automatically redirects the user to Special:UserLogin, instead of a custom error message. We will need to add our error message using the LoginFormValidErrorMessages hook.

I will mentor this task in GCI 2015.

Details

SubjectRepoBranchLines +/-
Redirect anonymous user to login page from Special:Notificationsmediawiki/extensions/Echomaster+12 -10
Customize query in gerrit

Event Timeline

Legoktm created this task.Nov 17 2015, 5:38 PM
Legoktm raised the priority of this task from to Low.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Notifications, good first task, Google-Code-In-2015.
Legoktm subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 17 2015, 5:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a comment.Dec 5 2015, 8:45 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/5148915577913344/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 5 2015, 8:45 PM
Mhutti1 claimed this task.Dec 8 2015, 5:24 PM
Mhutti1 added a comment.Dec 8 2015, 7:04 PM

I have uploaded a patch https://gerrit.wikimedia.org/r/#/c/257661/

gerritbot subscribed.Dec 8 2015, 7:41 PM

Change 257661 had a related patch set uploaded (by Mhutti1):
Redirects annonomous user to login page from Special:Notifications

https://gerrit.wikimedia.org/r/257661

gerritbot added a project: Patch-For-Review.Dec 8 2015, 7:41 PM
Legoktm closed this task as Resolved.Dec 8 2015, 7:58 PM

Awesome work!

gerritbot added a comment.Dec 8 2015, 7:59 PM

Change 257661 merged by jenkins-bot:
Redirect anonymous user to login page from Special:Notifications

https://gerrit.wikimedia.org/r/257661

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 8 2015, 8:00 PM
Legoktm edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Dec 9 2015, 7:22 AM
Legoktm set Security to None.
Legoktm moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
Catrope moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Dec 17 2015, 7:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL