Maniphest T119648

Fix getLagFromPtHeartbeat() to use the pt entry for the root master, not the immediate one
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Nov 25 2015, 6:54 PM

Description

The MW code for getting pt-heartbeat lag checks the row for Master_Server_Id (from the slave status), which for master => slave1 => slave2, would check for the slave1 id entry (which wouldn't even exist since only the true masters get table updates for their server IDs)

Details

	Subject	Repo	Branch	Lines +/-
	Make getLagFromPtHeartbeat() always use the LB cluster master entry	mediawiki/core	master	+164 -23

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	aaron	T88445 MediaWiki active/active datacenter investigation and work (tracking)
Resolved	aaron	T111266 Make LoadBalancer slave lag check and read-only mode more robust (for example, using pt-heartbeat)
Resolved	aaron	T119648 Fix getLagFromPtHeartbeat() to use the pt entry for the root master, not the immediate one

Event Timeline

aaron created this task.Nov 25 2015, 6:54 PM

aaron claimed this task.

aaron raised the priority of this task from to Needs Triage.

aaron updated the task description. (Show Details)

aaron added projects: WMF-General-or-Unknown, Performance-Team, Patch-For-Review, DBA, Performance Issue, Sustainability.

aaron added subscribers: Glaisher, gerritbot, • jcrespo and 2 others.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 25 2015, 6:54 PM

aaron renamed this task from Fixed getLagFromPtHeartbeat() to use the pt entry for the root master, not the immediate one to Fix getLagFromPtHeartbeat() to use the pt entry for the root master, not the immediate one.Nov 25 2015, 6:58 PM

aaron removed a project: Patch-For-Review.

aaron set Security to None.

ori triaged this task as Low priority.Nov 30 2015, 7:42 PM

ori moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

aaron moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.Dec 3 2015, 8:38 PM

Change 256875 had a related patch set uploaded (by Aaron Schulz):
Make getLagFromPtHeartbeat() always use the LB cluster master entry

https://gerrit.wikimedia.org/r/256875

gerritbot added a project: Patch-For-Review.Dec 4 2015, 12:59 AM

Nemo_bis removed a project: WMF-General-or-Unknown.Dec 5 2015, 2:19 PM

aaron moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Dec 13 2015, 9:30 PM

Change 256875 merged by jenkins-bot:
Make getLagFromPtHeartbeat() always use the LB cluster master entry

https://gerrit.wikimedia.org/r/256875