Page MenuHomePhabricator
Create Task
Maniphest T119902

[Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined"

Screen Shot 2015-11-30 at 12.52.57 PM.png (744×1 px, 290 KB)

Details

SubjectRepoBranchLines +/-
Fixed regression crash on graphless pagesmediawiki/extensions/Graphmaster+1 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Nov 30 2015, 8:54 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added subscribers: Aklapper, StudiesWorld, Ryasmeen.
Ryasmeen added a project: Graph-VisualEditor.Nov 30 2015, 8:57 PM
Ryasmeen set Security to None.
Jdforrester-WMF assigned this task to • ferdbold.Dec 1 2015, 8:07 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF edited a custom field.
• ferdbold added a comment.Dec 2 2015, 9:28 PM

This is weird, I'm able to reproduce this. Graphs in read mode aren't being rendered, though if I go save some edit through wikitext editor, everything works well again. This is surely related to the new vega2 support ext.graph is doing

Investigating

gerritbot subscribed.Dec 3 2015, 4:57 AM

Change 256626 had a related patch set uploaded (by Ferdbold):
Fixed regression crash on graphless pages

https://gerrit.wikimedia.org/r/256626

gerritbot added a project: Patch-For-Review.Dec 3 2015, 4:57 AM
• ferdbold added a project: MediaWiki-extensions-Graph.Dec 3 2015, 5:04 AM
• ferdbold moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.
gerritbot added a comment.Dec 3 2015, 3:24 PM

Change 256626 merged by jenkins-bot:
Fixed regression crash on graphless pages

https://gerrit.wikimedia.org/r/256626

Jdforrester-WMF closed this task as Resolved.Dec 3 2015, 3:33 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits