Maniphest T120197

[Bug] different display of items with no label on Special:Nearby
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Dec 3 2015, 11:22 AM

Description

On Wikidata's Special:Nearby items with no label are not shown consistently. Some how up with just the QId and others with "No label defined (QId)". They should always be shown consistently. I'd prefer the version with "No label defined" text.

Details

Subject	Repo	Branch	Lines +/-
Introduce $wgMFSearchUseDisplayTitle	mediawiki/extensions/MobileFrontend	master	+17 -11
Set only title text in ParserOutput (and not display title property)	mediawiki/extensions/Wikibase	master	+1 -1
Don't request pageprops for mobile search/nearby on wikidata	operations/mediawiki-config	master	+1 -1
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php	operations/mediawiki-config	master	+17 -6

Customize query in gerrit

Revisions and Commits

rOMWC Wikimedia - MediaWiki Config
	rOMWCd558216294ae Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T120197 [Bug] different display of items with no label on Special:Nearby
		Duplicate		None	T121378 Impossible to override an array-valued global created by extension registration

Event Timeline

Lydia_Pintscher created this task.Dec 3 2015, 11:22 AM

Lydia_Pintscher raised the priority of this task from to Medium.

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

Lydia_Pintscher added subscribers: Lydia_Pintscher, aude.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2015, 11:22 AM

"No label defined" is display title, when we have it. I'm not sure we can always have or should have display title. I think just displaying the title (Q##) would be more simple here.

also having language fallback is a possibility

Ok.
Language fallback is in another ticket. We should have it.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Dec 3 2015, 3:31 PM

Change 268182 had a related patch set uploaded (by Aude):
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

gerritbot added a project: Patch-For-Review.Feb 3 2016, 6:18 PM

Change 268182 merged by jenkins-bot:
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

aude closed this task as Resolved by committing rOMWCd558216294ae: Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php.Feb 3 2016, 7:47 PM

aude added a commit: rOMWCd558216294ae: Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php.

aude reopened this task as Open.Feb 3 2016, 8:32 PM

aude set Security to None.

Change 268208 had a related patch set uploaded (by Aude):
Don't request pageprops for mobile search/nearby on wikidata

https://gerrit.wikimedia.org/r/268208

we are still requesting pageprops and without specifying which one we want, then we still get displaytitle along with all the others.

Change 268208 merged by jenkins-bot:
Don't request pageprops for mobile search/nearby on wikidata

https://gerrit.wikimedia.org/r/268208

aude added a subtask: T121378: Impossible to override an array-valued global created by extension registration.Feb 8 2016, 9:43 PM

Sjoerddebruin subscribed.Feb 8 2016, 9:44 PM

aude removed a project: Patch-For-Review.Feb 8 2016, 9:51 PM

Change 282144 had a related patch set uploaded (by Aude):
Set only title text in ParserOutput (and not display title property)

https://gerrit.wikimedia.org/r/282144

gerritbot added a project: Patch-For-Review.Apr 7 2016, 12:21 PM

Change 282144 merged by jenkins-bot:
Set only title text in ParserOutput (and not display title property)

https://gerrit.wikimedia.org/r/282144

Lydia_Pintscher closed this task as Resolved.Apr 14 2016, 3:34 PM

Lydia_Pintscher claimed this task.

Change 269258 abandoned by Jdlrobson:
Introduce $wgMFSearchUseDisplayTitle

Reason:
Given the bug was resolved I can only assume this is no longer needed. Apologies if I'm wrong - by all means feel free to reopen it in that case.

https://gerrit.wikimedia.org/r/269258

hoo mentioned this in T141175: Special:Nearby doesn't show human readable labels on Wikidata (shows item id).Jul 26 2016, 11:30 AM

[Bug] different display of items with no label on Special:NearbyClosed, ResolvedPublicActions