Page MenuHomePhabricator
Create Task
Maniphest T120227

Interactive graph keeps repainting on mousemove in read mode
Closed, ResolvedPublic
Actions

Description

For interactive graph like http://en.wikipedia.beta.wmflabs.org/wiki/DynamicGraph3 , once made interactive, the graph rapidly repaints on mouse move. This does NOT happen in the edit preview mode.

Debugging Notes

  • Adding tracing to vega.js prototype.mousemove showed that the object returned from pickEvent kept being different from the active one when moving the mouse within the same large circle.
  • Tracing prototype.pick showed that scene.marktype kept altering between group, path, and text values, whereas in preview it only showed group and path, but not text.

Related Objects

Event Timeline

Yurik created this task.Dec 3 2015, 3:45 PM
Yurik raised the priority of this task from to High.
Yurik updated the task description. (Show Details)
Yurik added a project: MediaWiki-extensions-Graph.
Yurik added subscribers: Yurik, • JGirault.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2015, 3:45 PM
Yurik moved this task from Backlog to Prioritized on the MediaWiki-extensions-Graph board.Dec 3 2015, 3:53 PM
Yurik set Security to None.Dec 3 2015, 6:51 PM
Yurik added a subscriber: Krinkle.
Yurik added a comment.Dec 4 2015, 12:14 AM

I think I found the issue - and its with the data, not Vega. API module does not return data "as is" - instead the json formatter removes certain values, such as "blah":false -- because it is identical to not having a value (javascript return undefined). It seems vega actually checks for the value, hence the difference.

Yurik closed this task as Resolved.Dec 4 2015, 1:12 AM
Yurik claimed this task.

Fixed with https://gerrit.wikimedia.org/r/#/c/256877/

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 4 2015, 2:00 AM
Yurik mentioned this in T120380: RFC: Allow JSON values to be included in the API results .Dec 4 2015, 3:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits