Page MenuHomePhabricator

Special:Nearby has broken hybrid styles for mw.notify
Closed, ResolvedPublic

Description

When triggering mw.notify from a user script or MediaWiki core module (e.g. global events unrelated to the current page), something strange happens if currently on Special:Nearby.

Expected:

Something like this

Screen Shot 2015-12-04 at 14.05.42.png (336×1 px, 59 KB)

Actual:

A dark fullscreen overlay with a bright bubble containing unreadable white text.

Screen Shot 2015-12-03 at 19.44.37.png (1×2 px, 137 KB)

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle subscribed.
Jdlrobson subscribed.

yuck. These styles should be only loaded in Minerva so not quite sure why this is happening.

Florian subscribed.

That's a dependency to mobile.toast for mobile.watchlist, which is a dependency of mobile.pagelist.scripts. mobile.pagelist.scripts is needed by mobile.nearby and therefor loaded in mobile.special.nearby.scripts, too.

Change 256964 had a related patch set uploaded (by Florianschmidtwelzow):
Fix mobile.toast styles in desktop skins

https://gerrit.wikimedia.org/r/256964

Change 256964 merged by jenkins-bot:
Fix mobile.toast styles in desktop skins

https://gerrit.wikimedia.org/r/256964

This has greatest a regression: 120671
There may be other regressions due to toasts not styling in other places where notifications are caused by special pages that exist in MobileFrontend and use toast code.